Shared helper for making venvs in tests#258
Merged
Merged
Conversation
Contributor
|
Thanks for the quick fix @ngoldbaum |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #255.
The
test_zintegrationalready had a helper for setting up a venv. This updates that helper to use a.pthfile instead of the old filesystem walking which needed some special code to work on PyPy.The helper creates a venv with the stdlib
venvmodule and writes a.pthfile into itssite-packagescontainingimport site; site.addsitedir(...)lines for the site directories of the environment running the tests. The venv can then import everything the tests need from the environment that already has them.The
.pthfile callssite.addsitedir()rather than listing bare paths becauseaddsitedir()also processes.pthfiles inside the added directories — this keeps setuptools' distutils shim (needed by the zintegration snippets on 3.12+) and editable installs working.