Repository navigation
ci: keep requests in the async fallback jobs - #857
Merged
Merged
Conversation
The three async fallback jobs uninstall niquests, but the tests also import the sync client (caldav.discovery, caldav.testing, test_caldav_unit), which then needs requests. Radicale pulled requests in until 3.9.0; 3.9.1 does not, so all three jobs failed at import on every branch. Install requests explicitly in those jobs. Prompt: merge #855 and #856 Followup-Prompt: yes, [fix the CI breakage, by installing requests in the three async fallback jobs, on its own branch, and merge it first] Assisted-By: Claude Opus 5.5 <noreply@anthropic.com> Reviewed-by: Tobias Brox <tobias@redpill-linpro.com>
tobixen
force-pushed
the
ci/fallback-keep-requests
branch
from
November 12, 2026 19:13
51a8d55 to
12ef8dd
Compare
tobixen
marked this pull request as ready for review
November 12, 2026 19:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit message:
The three async fallback jobs uninstall niquests, but the tests also
import the sync client (caldav.discovery, caldav.testing,
test_caldav_unit), which then needs requests. Radicale pulled
requests in until 3.9.0; 3.9.1 does not, so all three jobs failed at
import on every branch. Install requests explicitly in those jobs.
Prompt: merge #855 and #856
Followup-Prompt: yes, [fix the CI breakage, by installing requests in the three async fallback jobs, on its own branch, and merge it first]
Assisted-By: Claude Opus 5.5 noreply@anthropic.com
The underlying library issue (async discovery needs a sync HTTP library) is filed separately.