Repository navigation
461 serializedmagnets - #481
Draft
gupichon-soleil wants to merge 2 commits into
Draft
gupichon-soleil wants to merge 2 commits into
gupichon-soleil wants to merge 2 commits into
Conversation
A serialized family (N magnets on one power supply) has a single degree of freedom, the PS current I. The accessors now follow that in design and live: - family.hardware returns I (was N x I) and sets I. - family.strength returns the average strength sum(f_i(I))/N and sets the I that gives it (exact inverse of the piecewise-linear curves). - magnet[i].strength sets I = f_i^-1(x) with the magnet's own submodel; the other magnets follow. Design no longer splits the value by length. - Array writes give the PS the mean of the currents asked by the series members present in the array, not by all N, so writing one member no longer moves the PS by 1/N. Inconsistent requests log a warning. Design arrays (no aggregator) apply the same rule as live. Combined-function magnets keep their current behaviour: the strength aggregator now calls MagnetModel.compute_hardware_values_partial(), whose default is the previous logic; LinearSerializedMagnetModel overrides it. Also: - Build the serialized submodels once, at configuration. Attaching a family used to rebuild them, so the per-magnet accessors kept stale submodels that never received the magnetic rigidity. - SerializedMagnetsArray.unit() no longer splits unit strings into characters. - Remove ReadWriteSerializedStrengths.elements / get_elements(); use SerializedMagnets.get_magnets(). Tests: new design/live tests for idempotence, family values, per-magnet writes, design/live parity and array writes; tests that relied on the sum and length-sharing convention are updated. Refs #461 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…alized-accessors Implement the agreed serialized-magnet accessor convention
gupichon-soleil
requested review from
GamelinAl,
JeanLucPons,
TeresiaOlsson and
kparasch
October 15, 2026 08:15
JeanLucPons
approved these changes
Oct 15, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.