fix(rewrite): freeze walrus and starred operands too - #14814
Draft
RonnyPfannschmidt wants to merge 2 commits into
Draft
fix(rewrite): freeze walrus and starred operands too#14814RonnyPfannschmidt wants to merge 2 commits into
RonnyPfannschmidt wants to merge 2 commits into
Conversation
psf-chronographer
Bot
added
the
bot:chronographer:provided
RonnyPfannschmidt
force-pushed
the
ronny/fix-walrus-raw-operands
branch
from
July 31, 2026 19:04
16b94a1 to
cc6afa4
Compare
This was referenced Jul 31, 2026
RonnyPfannschmidt
force-pushed
the
ronny/fix-walrus-raw-operands
branch
from
July 31, 2026 20:18
cc6afa4 to
d271ad5
Compare
This was referenced Jul 31, 2026
RonnyPfannschmidt
force-pushed
the
ronny/fix-walrus-raw-operands
branch
from
August 10, 2026 07:12
d271ad5 to
5af71a7
Compare
RonnyPfannschmidt
force-pushed
the
ronny/fix-walrus-raw-operands
branch
from
August 20, 2026 04:35
5af71a7 to
fd41d89
Compare
This was referenced Aug 20, 2026
RonnyPfannschmidt
force-pushed
the
ronny/fix-walrus-raw-operands
branch
4 times, most recently
from
August 26, 2026 10:04
837173f to
338cd67
Compare
visit_operand() only froze a bare name, so two other unhoisted operands
kept being evaluated after everything that follows them:
assert collect((x := 1), identity(x := 2)) == (1, 2)
assert collect(*items, identity(items := [9])) == (1, [9])
A walrus operator left in place assigns once the enclosing expression is
assembled, which is after the later arguments have run -- so the earlier
argument saw the later assignment. A starred argument hid its value
inside an ast.Starred, where the existing Name check could not see it.
Closes the order-starred-argument group and the remaining
order-call-argument entry in the coverage matrix.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
…eeds visit_operand freezes a walrus operand whenever anything follows it, and a comparison always has at least one comparator -- so by the time visit_Compare looks at its left operand, a NamedExpr has already been copied into a temporary. The special case that did it here can never run. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
RonnyPfannschmidt
force-pushed
the
ronny/fix-walrus-raw-operands
branch
from
September 1, 2026 11:54
338cd67 to
6446871
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #14447 → #14921 → #14813. Its diff includes theirs.
visit_operand()(added in #14447) only froze a bare name, so two other unhoisted operands kept being evaluated after everything that follows them:A walrus operator left in place assigns only once the enclosing expression is assembled, which is after the later arguments have run — so the earlier argument saw the later assignment. A starred argument hid its value inside an
ast.Starred, where the existingNamecheck could not reach it.Lands the
order-starred-argumentcase and the lastorder-call-argumentcase of the coverage matrix in #14813, as passing tests (+2).The starred case was found by the matrix, not by hand — it is what the
order-*axis is for.