Reset Polyfactory's random state on each test#735
Open
pctablet505 wants to merge 2 commits into
Open
Conversation
Polyfactory maintains its own default random.Random() instance (polyfactory.constants.DEFAULT_RANDOM) separate from Faker's, so it wasn't being reseeded alongside the other supported libraries. Follows the existing pattern used for factory_boy, Faker, Model Bakery, and NumPy: reseed if the library is importable. Closes pytest-dev#720.
The int field was generated via Polyfactory's Faker instance, whose random generator pytest-randomly already reseeds independently of this change, so the test passed whether or not DEFAULT_RANDOM was reset. Switch to a Union-typed field so the assertion depends on DEFAULT_RANDOM.choice() picking which type to build, which does regress to a different value if the reseed is removed.
pctablet505
marked this pull request as ready for review
July 17, 2026 12:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Polyfactory keeps its own default
random.Random()instance (polyfactory.constants.DEFAULT_RANDOM) separate from Faker's, so it wasn't being reseeded along with the other libraries pytest-randomly already supports.This adds Polyfactory to the same try/except reseed pattern used for factory_boy, Faker, Model Bakery, and NumPy, so factories using the default random generator get deterministic, per-test values under
--randomly-seed. Factories that callseed_random()themselves are unaffected, same as before.Closes #720.