Skip to content

Fix path traversal via symlink in embedded_get() #5090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AAtomical wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −2
Open

Fix path traversal via symlink in embedded_get() #5090

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/__main__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -356,8 +356,8 @@ def embedded_get(args):
if not args.unsafe and not args.output:
if os.path.exists(filename):
sys.exit(f'refusing to overwrite existing file with stored name: {filename}')
filename_abs = os.path.abspath(filename)
if not filename_abs.startswith(os.getcwd() + os.sep):
filename_real = os.path.realpath(filename)
if not filename_real.startswith(os.path.realpath(os.getcwd()) + os.sep):
sys.exit(f'refusing to write stored name outside current directory: {filename}')
with open(filename, "wb") as output:
output.write(stream)
Expand Down
Loading