Skip to content

Chore: consistent metadata in wheels - #5088

Open
dimbleby wants to merge 1 commit into
pymupdf:mainfrom
dimbleby:consistent-metadata
Open

Chore: consistent metadata in wheels#5088
dimbleby wants to merge 1 commit into
pymupdf:mainfrom
dimbleby:consistent-metadata

Conversation

@dimbleby

Copy link
Copy Markdown

I do not fully understand why pipcl and pytest become project dependencies on pyodide only, but the best way to express that is through environment markers. Else, wheels uploaded to pypi contain different metadata.

Cross-platform resolvers like uv and poetry typically just look at one wheel and trust that all have the same requirements: so depending on which they happen to look at: you are either getting pipcl and pytest always installed, or never installed.

Signaling the requirement through static metadata allows the right answer to be reached on all platforms.

@github-actions

Copy link
Copy Markdown
Contributor


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@dimbleby

Copy link
Copy Markdown
Author

I will not be signing a CLA, you are welcome to this code, take it or leave it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant