Chore: consistent metadata in wheels - #5088
Open
dimbleby wants to merge 1 commit into
Open
Conversation
Contributor
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
Author
|
I will not be signing a CLA, you are welcome to this code, take it or leave it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I do not fully understand why
pipclandpytestbecome project dependencies on pyodide only, but the best way to express that is through environment markers. Else, wheels uploaded to pypi contain different metadata.Cross-platform resolvers like uv and poetry typically just look at one wheel and trust that all have the same requirements: so depending on which they happen to look at: you are either getting pipcl and pytest always installed, or never installed.
Signaling the requirement through static metadata allows the right answer to be reached on all platforms.