Fix test_server_isLatest when using plexpass container tag#1616
Merged
JonnyWong16 merged 2 commits intoJun 18, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes the test_server_isLatest test logic to avoid failing when the Plex server is started from rolling container tags (notably plexpass), where an update may legitimately not be available.
Changes:
- Treat
PLEX_CONTAINER_TAGvalueslatest,plexpass, andpublicas “rolling” tags and skip the “update must be available” assertion for those tags.
Comments suppressed due to low confidence (1)
tests/test_server.py:254
- The skip message still says
PLEX_CONTAINER_TAG != latest, but the condition now treatsplexpassandpublicthe same aslatest(i.e., it will also skip). Updating the message will avoid confusing guidance when running tests in CI withplexpass/publictags.
if environ.get("PLEX_CONTAINER_TAG") and environ["PLEX_CONTAINER_TAG"] not in ("latest", "plexpass", "public"):
assert not is_latest
else:
return pytest.skip(
"Do not forget to run with PLEX_CONTAINER_TAG != latest to ensure that update is available"
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix
test_server_isLatestwhen usingplexpasscontainer tag.Type of change
Please delete options that are not relevant.
Checklist: