Skip to content

Fix test_server_isLatest when using plexpass container tag#1616

Merged
JonnyWong16 merged 2 commits into
pushingkarmaorg:masterfrom
JonnyWong16:hotfix/test_server_islatest
Jun 18, 2026
Merged

Fix test_server_isLatest when using plexpass container tag#1616
JonnyWong16 merged 2 commits into
pushingkarmaorg:masterfrom
JonnyWong16:hotfix/test_server_islatest

Conversation

@JonnyWong16

Copy link
Copy Markdown
Collaborator

Description

Fix test_server_isLatest when using plexpass container tag.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the docstring for new or existing methods
  • I have added tests when applicable

Copilot AI review requested due to automatic review settings June 18, 2026 23:32

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes the test_server_isLatest test logic to avoid failing when the Plex server is started from rolling container tags (notably plexpass), where an update may legitimately not be available.

Changes:

  • Treat PLEX_CONTAINER_TAG values latest, plexpass, and public as “rolling” tags and skip the “update must be available” assertion for those tags.
Comments suppressed due to low confidence (1)

tests/test_server.py:254

  • The skip message still says PLEX_CONTAINER_TAG != latest, but the condition now treats plexpass and public the same as latest (i.e., it will also skip). Updating the message will avoid confusing guidance when running tests in CI with plexpass/public tags.
    if environ.get("PLEX_CONTAINER_TAG") and environ["PLEX_CONTAINER_TAG"] not in ("latest", "plexpass", "public"):
        assert not is_latest
    else:
        return pytest.skip(
            "Do not forget to run with PLEX_CONTAINER_TAG != latest to ensure that update is available"

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@JonnyWong16 JonnyWong16 merged commit 76f6994 into pushingkarmaorg:master Jun 18, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants