Repository navigation
fix: pin the Node version in the shared build surface - #41
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The shared build surface sets up .NET and Bun but never Node, so
astro check(and any other JavaScript tooling) inherits whatevernodetheubuntu-latestimage happens to expose. That drifts between runner images: an identical commit passed at 10:07 and failed at 18:40 withRe-running the same commit then passed, confirming the failure was the runner environment, not the code.
Change
Pin Node at every site that already sets up Bun, and expose it as an optional
node-versioninput (default26.x, the current LTS) alongside the existingdotnet-versioninput:.github/workflows/purview-build.yml- reusable PR/build workflow.github/workflows/purview-release.yml- threads the new input to the release actionactions/purview-release/action.yml- composite release action.github/actions/purview-build/action.yml- composite build actionThe input is additive and optional, so existing callers are unaffected.
Notes
Purview.Buildversion bump: this is a workflow/action-only change, picked up at@main.actionlintcheck passes.