Skip to content

fix: stop counting Obsoleting Packages rows as updates; correct 0.3.0 Windows notes (0.3.1) - #3

Open
matthewrstone wants to merge 2 commits into
mainfrom
fix/0.3.1-review-findings
Open

matthewrstone wants to merge 2 commits into
mainfrom
fix/0.3.1-review-findings

Conversation

@matthewrstone

Copy link
Copy Markdown
Collaborator

Summary

  • WR-01: yum -q check-update and dnf -q check-update print an Obsoleting Packages section after the real updates. The yum filter counted both the replacing and the replaced rows, and the dnf filter let the indented replaced row through, so available, package_count and packages[] could be too high. Both branches now stop reading at the Obsoleting Packages header.
  • WR-02: CHANGELOG correction. The 0.3.0 notes said a version 1 reader keeps working; that holds for Linux, but on Windows facts.d/patchbot.ps1 no longer emits patches[] (readers must move to missing[]).

Both come from the Stagehand console Phase 72.3 code review; the console's lab development copy already carries the WR-01 fix. security <= available held before and still holds.

Release notes

CHANGELOG has a 0.3.1 (unreleased) entry; metadata.json is still 0.3.0. Bump it and tag v0.3.1 at release time (the release workflow still needs the PDK step, so publish by hand as for v0.3.0).

Test plan

  • Console repo lab/code/modules/patchbot/tests/patchbot_test.sh (same fact): 153 ok / 0 not ok
  • hack/patchbot-fact-dnf-security-smoke.sh on real AlmaLinux 8.9: 7/7; hack/patchbot-fact-el7-smoke.sh on real CentOS 7: 4/4
  • CI on this repository (the Ruby 4.0 unit leg is a known pre-existing red)

🤖 Generated with Claude Code

https://claude.ai/code/session_01McuAWfE22TvftB9SGnvzTT

matthewrstone and others added 2 commits November 19, 2026 08:51
…n yum and dnf

Re-propagates the development copy of facts.d/patchbot.sh (byte-identical,
checked with cmp). The yum branch counted the replacing and replaced rows
of an Obsoleting Packages section as pending updates; both branches now
stop at the header. CHANGELOG records the fix under 0.3.1 (unreleased).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01McuAWfE22TvftB9SGnvzTT
…mitted from 0.3.0

The 0.3.0 notes say a version 1 reader keeps working and everything else
is additive. On Windows that is false: patches[] is replaced by missing[],
and os_build, installed_kbs, cache_age_seconds and others are added. Records
the change under 0.3.1 (unreleased) without rewriting the 0.3.0 entry, and
marks the 0.2.0 Windows line as superseded in 0.3.0.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01McuAWfE22TvftB9SGnvzTT
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant