Repository navigation
fix: stop counting Obsoleting Packages rows as updates; correct 0.3.0 Windows notes (0.3.1) - #3
Open
matthewrstone wants to merge 2 commits into
Open
matthewrstone wants to merge 2 commits into
matthewrstone wants to merge 2 commits into
Conversation
…n yum and dnf Re-propagates the development copy of facts.d/patchbot.sh (byte-identical, checked with cmp). The yum branch counted the replacing and replaced rows of an Obsoleting Packages section as pending updates; both branches now stop at the header. CHANGELOG records the fix under 0.3.1 (unreleased). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01McuAWfE22TvftB9SGnvzTT
…mitted from 0.3.0 The 0.3.0 notes say a version 1 reader keeps working and everything else is additive. On Windows that is false: patches[] is replaced by missing[], and os_build, installed_kbs, cache_age_seconds and others are added. Records the change under 0.3.1 (unreleased) without rewriting the 0.3.0 entry, and marks the 0.2.0 Windows line as superseded in 0.3.0. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01McuAWfE22TvftB9SGnvzTT
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
yum -q check-updateanddnf -q check-updateprint anObsoleting Packagessection after the real updates. The yum filter counted both the replacing and the replaced rows, and the dnf filter let the indented replaced row through, soavailable,package_countandpackages[]could be too high. Both branches now stop reading at theObsoleting Packagesheader.facts.d/patchbot.ps1no longer emitspatches[](readers must move tomissing[]).Both come from the Stagehand console Phase 72.3 code review; the console's lab development copy already carries the WR-01 fix.
security <= availableheld before and still holds.Release notes
CHANGELOG has a
0.3.1 (unreleased)entry;metadata.jsonis still0.3.0. Bump it and tagv0.3.1at release time (the release workflow still needs the PDK step, so publish by hand as for v0.3.0).Test plan
lab/code/modules/patchbot/tests/patchbot_test.sh(same fact): 153 ok / 0 not okhack/patchbot-fact-dnf-security-smoke.shon real AlmaLinux 8.9: 7/7;hack/patchbot-fact-el7-smoke.shon real CentOS 7: 4/4🤖 Generated with Claude Code
https://claude.ai/code/session_01McuAWfE22TvftB9SGnvzTT