(MODULES-11710) Add Puppet 9 support by skyamgarp · Pull Request #1482 · puppetlabs/puppetlabs-stdlib

skyamgarp · 2026-07-22T13:34:19Z

Summary

Adds Puppet 9 support to puppetlabs-stdlib, following the same pattern established in puppetlabs-apache#2638 (MODULES-11700).

Jira: MODULES-11710

What's included

metadata.json: raises the Puppet upper bound (< 9.0.0 → < 10.0.0) and drops EOL platforms that Puppet 8/9 don't ship agents for (EL7 family, CentOS 8, Debian 10, SLES 12, Ubuntu 18.04).
Version-conditional lint tooling (Gemfile): the Puppet 9 lane runs on Ruby 3.4+, where puppet-lint 4.x crashes; the Puppet 7/8 lane runs on Ruby 3.1, where voxpupuli-puppet-lint-plugins ~> 7.0 won't resolve. Gated behind a puppet9_stream check derived from PUPPET_GEM_VERSION, keeping released tooling on 7/8.
strict_indent disabled (Rakefile): puppet-lint-strict_indent-check demands opposite indentation between the 3.x (7/8) and 5.x (9) plugin versions, so no single manifest layout passes both lanes.
Puppet 9 gem source (Gemfile): the 8.99.x prerelease is fetched via PUPPET_GEM_SOURCE (internal Artifactory), reachable over Twingate in CI.
ci.yml: Spec job points at the cat-github-actions branch that wires PUPPET_GEM_SOURCE/Twingate for the Puppet 9 lane; Acceptance flags gain --collection-platform-exclude 9:ubuntu-20.04 (Focal has no Puppet 9 agent).

Dependencies

Like the Apache PR, this temporarily pins two companion branches; both should revert to released refs once merged:

puppet_litmus #627 — adds --collection-platform-exclude to matrix_from_metadata_v3 (Gemfile pins the branch).
cat-github-actions #182 — passes PUPPET_GEM_SOURCE + Twingate for the Puppet 9 spec lane (ci.yml Spec pins the branch).

Testing

bundle exec rake lint clean on Ruby 3.1 (Puppet 7/8 lane, current tooling).
bundle exec metadata-json-lint metadata.json clean.
Full classes/defines/functions/unit spec suite (1758 examples) passes; on_supported_os-driven specs correctly reflect the trimmed OS matrix.
Puppet 9 (Ruby 3.4 + Twingate/Artifactory) lane cannot be exercised locally; relies on CI once the companion branches are available.

🤖 Generated with Claude Code

shubhamshinde360

LGTM. Holding merge till get the puppet_litmus and puppetlabs_spec_helper gems released.

bastelfreak · 2026-07-29T11:10:12Z

  gem "deep_merge", '~> 1.2.2',                  require: false
-  gem "voxpupuli-puppet-lint-plugins", '~> 5.0', require: false
+  if puppet9_stream
+    gem "voxpupuli-puppet-lint-plugins", '~> 7.0', require: false


Doing different linting based on the puppet version just feels wrong. IMO this needs to be cleaned up before it's merged

bastelfreak · 2026-07-29T11:11:20Z

    {
      "operatingsystem": "RedHat",
      "operatingsystemrelease": [
-        "7",


Please tell me you don't plan to drop operating systems and don't even mention it in the PR title

Will address this in separate PR. Thanks.

bastelfreak · 2026-07-29T11:12:06Z

  "requirements": [
    {
      "name": "puppet",
-      "version_requirement": ">= 8.0.0 < 9.0.0"


IMO it's wrong to bump this when there is no version 9 available yet. We simply don't know if it will be compatible

With this PR we are testing against internal Puppet 9 version.

That's fine for testing, but IMO it shouldn't be merged before public/official releases are available.

ekohl · 2026-07-29T12:11:17Z

+  # JSON.pretty_generate's formatting of empty arrays/hashes changed between json gem
+  # versions (older gems emit "[\n\n]"/"{\n}", newer ones emit the compact "[]"/"{}"), so
+  # assert against whatever the loaded json gem actually produces rather than a fixed string.
+  it { is_expected.to run.with_params([]).and_return("#{JSON.pretty_generate([])}\n") }


What's this test worth if it matches the implementation exactly?

The base branch was changed.

bastelfreak · 2026-08-03T12:09:44Z

+# between puppet-lint-strict_indent-check 3.x (Puppet 7/8 lane, Ruby 3.1) and 5.x
+# (Puppet 9 lane, Ruby 3.4+): the two lanes demand opposite indentation for nested
+# hashes, so no single manifest layout can satisfy both. See MODULES-11710.
+PuppetLint.configuration.send('disable_strict_indent')


IMO this is bad. The plugin is important and you should use the latest version, even on Puppet 8.

@main

Widens the puppet requirement to admit 9.0.x. Follows the current puppetlabs-stdlib#1482 pattern: voxpupuli-puppet-lint-plugins and puppetlabs_spec_helper are bumped unconditionally (no per-lane version split), since puppet-lint 7.0 (Ruby >= 3.2) is used across both the Puppet 7/8 and Puppet 9 lanes. puppetlabs_spec_helper is pinned to its git main branch until puppet-lint 5.x support ships in a release (puppetlabs/puppetlabs_spec_helper#485, merged but unreleased). ci.yml and mend.yml bump ruby_version to 3.2 to match, and Acceptance/ mend point at a temporary cat-github-actions branch (MODULES-11710-ruby-version-input) that adds a ruby_version input to module_acceptance.yml/mend_ruby.yml — both hardcode Ruby 3.1 otherwise, which can't resolve the new Gemfile. Swap back to @main once that branch merges. The puppet/facter gem source resolution is unchanged: Puppet 9 (8.99.x) prereleases are fetched via PUPPET_GEM_SOURCE, falling back to the existing puppetcore source when unset. This module's manifests already comply with puppet-lint-strict_indent- check 5.x, so no Rakefile change is needed (unlike the stdlib PR's earlier iteration) — verified locally with `rake lint` on Ruby 3.2. This branch intentionally does not touch operatingsystem_support; that work is split into a separate PR (OS add/drop, mirroring the same fleet-wide rollout) to keep pre-existing, separately-tracked provisioning issues (CAT-2152, CAT-2511) off this PR. Ref: puppetlabs/puppetlabs-stdlib#1482 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

Bumps the puppet version_requirement to < 10.0.0, drops EOL platforms Puppet 8/9 don't ship agents for (EL7 family, CentOS 8, Debian 10, SLES 12, Ubuntu 18.04), gates lint tooling (voxpupuli-puppet-lint-plugins, puppetlabs_spec_helper, puppet_litmus) and the puppet/facter gem source behind a Puppet 9 (8.99.x) stream check in the Gemfile, disables the strict_indent lint check whose rules conflict between the two plugin versions, and wires ci.yml to the companion branches needed for the Puppet 9 spec/acceptance lanes. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

skyamgarp force-pushed the MODULES-11710 branch 6 times, most recently from 600bcf7 to aa6accf Compare July 28, 2026 08:33

shubhamshinde360 previously approved these changes Jul 29, 2026

View reviewed changes

skyamgarp mentioned this pull request Jul 29, 2026

(MODULES-11705) Add Puppet 9 support puppetlabs/puppetlabs-ntp#745

Open

skyamgarp marked this pull request as ready for review July 29, 2026 10:53

skyamgarp requested review from a team, alexjfisher, b4ldr, bastelfreak, ekohl, seanmil and smortex as code owners July 29, 2026 10:53

bastelfreak requested changes Jul 29, 2026

View reviewed changes

ekohl reviewed Jul 29, 2026

View reviewed changes

skyamgarp mentioned this pull request Jul 30, 2026

Drop EOL operating systems from operatingsystem_support #1483

Open

skyamgarp force-pushed the MODULES-11710 branch from aa6accf to d5de00f Compare July 31, 2026 05:35

skyamgarp changed the base branch from main to drop-eol-os-support July 31, 2026 05:36

skyamgarp mentioned this pull request Jul 31, 2026

Drop EOL platforms, add newer RedHat/CentOS releases puppetlabs/puppetlabs-ntp#746

Open

skyamgarp force-pushed the MODULES-11710 branch from d5de00f to 2dcc44f Compare August 3, 2026 09:23

skyamgarp changed the base branch from drop-eol-os-support to main August 3, 2026 10:41

bastelfreak reviewed Aug 3, 2026

View reviewed changes

skyamgarp force-pushed the MODULES-11710 branch 4 times, most recently from cf16fd0 to ed9f1e8 Compare August 3, 2026 15:11

skyamgarp force-pushed the MODULES-11710 branch from ed9f1e8 to 948780a Compare August 3, 2026 16:34

skyamgarp force-pushed the MODULES-11710 branch 2 times, most recently from fd4c5bd to b276a3a Compare August 6, 2026 12:55

skyamgarp force-pushed the MODULES-11710 branch from b276a3a to 4fe4368 Compare August 6, 2026 16:13

Navigation Menu

Uh oh!

(MODULES-11710) Add Puppet 9 support - #1482

(MODULES-11710) Add Puppet 9 support#1482
skyamgarp wants to merge 1 commit into
mainfrom
MODULES-11710

skyamgarp commented Jul 22, 2026

Uh oh!

shubhamshinde360 left a comment

Uh oh!

bastelfreak Jul 29, 2026

Uh oh!

bastelfreak Jul 29, 2026

Uh oh!

skyamgarp Jul 31, 2026

Uh oh!

bastelfreak Jul 29, 2026

Uh oh!

skyamgarp Jul 31, 2026

Uh oh!

bastelfreak Aug 3, 2026

Uh oh!

ekohl Jul 29, 2026

Uh oh!

bastelfreak Aug 3, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

skyamgarp commented Jul 22, 2026

Summary

What's included

Dependencies

Testing

Uh oh!

shubhamshinde360 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants