Fix docker_compose up_args

[mcarrolle]

Summary

Fix wrong position of up_args arguments passed to command and handle up_args argument that contains value like --pull always.
Issue: #984 and #996

Additional Context

Related Issues (if any)

• v10 uses docker arguments and options in the wrong order. #984
• up_args parameter for docker_compose doesn't handle argument with value #996

Checklist

• 🟢 Spec tests.
• 🟢 Acceptance tests.
• Manually verified. (For example puppet apply)

[KoenDierckx]

Any updates on this, it is blocking our upgrade of the module ?

[rogermartensson]

(I am not code owner)

I wonder if the argument validation for up_args is correct in the ruby-code for the docker_compose type?
Input should be an array but error says it should be a String.

I also notices that this pullrequests has failing CI-tests.

[jst-cyr]

@mcarrolle : Is this still an issue for you? It looks like the CI tests originally failed and have since been cleared out. There are also now branch conflicts with latest. Would you be able to update this and resolve any CI results that fail for unit testing?

(Note that acceptance testing will not succeed due to current limitations on the testing matrix config)

[mcarrolle]

Hi @jst-cyr — yes, the issue is still present. I’ve updated the branch: the changes fixing the placement of the up_args arguments and handling up_args values as an Array. Could you re-run the tests or check again? Thanks for the review.

[jst-cyr]

Running CI tests for this PR here: #1062