Skip to content

Update docker.rb for Podman - #994

Open
adamboutcher wants to merge 2 commits into
puppetlabs:mainfrom
adamboutcher:patch-1
Open

Update docker.rb for Podman#994
adamboutcher wants to merge 2 commits into
puppetlabs:mainfrom
adamboutcher:patch-1

Conversation

@adamboutcher

@adamboutcher adamboutcher commented Sep 4, 2024

Copy link
Copy Markdown

Summary

This if statement will enable the fact to work if you are using podman with docker symlink/support as the json syntax is lowercase on podman but camel/title case on docker.

Related Issues (if any)

#982
Possibly this too #749

Provide a detailed description of all the changes present in this pull request.
Just an if statement in the factor code (docker.rb)

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified. (For example puppet apply)

@adamboutcher
adamboutcher requested a review from a team as a code owner September 4, 2024 20:33
@CLAassistant

CLAassistant commented Sep 4, 2024

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

This if statement will enable the fact to work if you are using podman with docker symlink/support as the json syntax is lowercase on podman but camel/title case on docker.

As per - puppetlabs#982
Comment thread lib/facter/docker.rb Outdated
I'm not a ruby dev so I'll assume this works...

Co-authored-by: Henrik Hansson <h@rwx.nu>
@Henrik-Hansson

Copy link
Copy Markdown

Hi @torgeiou anything missing? I can try to help out in that case.

rockpapergoat pushed a commit to fasrc/puppetlabs-docker that referenced this pull request Sep 3, 2025

@sbernhard sbernhard left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with podman version 5.4.0 and it solves #982

@sbernhard

Copy link
Copy Markdown

Can someone of the maintainers, like @shubhamshinde360, @amitkarsale, @span786, @ghoneycutt, @bastelfreak merge this change?

@adamboutcher

Copy link
Copy Markdown
Author

Can someone of the maintainers, like @shubhamshinde360, @amitkarsale, @span786, @ghoneycutt, @bastelfreak merge this change?

I don't think perforce cares... A number of their modules have some serious compatibility issues which would be easy to resolve as they have pending PRs and nothing have been done, so I suspect this will remain the same.

@jst-cyr jst-cyr linked an issue Jun 30, 2026 that may be closed by this pull request
@jst-cyr

jst-cyr commented Jun 30, 2026

Copy link
Copy Markdown
Member

@adamboutcher @sbernhard : Apologies on the delay in getting responses here. I'm going through all the open PRs right now and trying to get them prioritized for the team.

It does look like the CLA hasn't been signed which might have been the reason this was blocked for so long? If so, we might have to open a new PR from engineering with the changes to bypass that blocker. I'll add this to the priority list and when the engineering team is able to review we'll see what we can do to get this updated.

@adamboutcher

Copy link
Copy Markdown
Author

It does look like the CLA hasn't been signed which might have been the reason this was blocked for so long?

I signed it 2 years ago...

@jst-cyr

jst-cyr commented Jun 30, 2026

Copy link
Copy Markdown
Member

@adamboutcher : Indeed, and I can see the CLA message saying that everybody had signed it after you submitted the PR, so I'm not sure what that license check is talking about (unless somebody sneaked something in and hadn't signed the CLA).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fact docker fail when podman is installed to emulate docker

6 participants