Update docker.rb for Podman - #994
Conversation
This if statement will enable the fact to work if you are using podman with docker symlink/support as the json syntax is lowercase on podman but camel/title case on docker. As per - puppetlabs#982
I'm not a ruby dev so I'll assume this works... Co-authored-by: Henrik Hansson <h@rwx.nu>
|
Hi @torgeiou anything missing? I can try to help out in that case. |
|
Can someone of the maintainers, like @shubhamshinde360, @amitkarsale, @span786, @ghoneycutt, @bastelfreak merge this change? |
I don't think perforce cares... A number of their modules have some serious compatibility issues which would be easy to resolve as they have pending PRs and nothing have been done, so I suspect this will remain the same. |
|
@adamboutcher @sbernhard : Apologies on the delay in getting responses here. I'm going through all the open PRs right now and trying to get them prioritized for the team. It does look like the CLA hasn't been signed which might have been the reason this was blocked for so long? If so, we might have to open a new PR from engineering with the changes to bypass that blocker. I'll add this to the priority list and when the engineering team is able to review we'll see what we can do to get this updated. |
I signed it 2 years ago... |
|
@adamboutcher : Indeed, and I can see the CLA message saying that everybody had signed it after you submitted the PR, so I'm not sure what that license check is talking about (unless somebody sneaked something in and hadn't signed the CLA). |
Summary
This if statement will enable the fact to work if you are using podman with docker symlink/support as the json syntax is lowercase on podman but camel/title case on docker.
Related Issues (if any)
#982
Possibly this too #749
Provide a detailed description of all the changes present in this pull request.
Just an if statement in the factor code (docker.rb)
Checklist
puppet apply)