fix: Improve group parsing in asound-fix.c and handle errors gracefully#79
Open
pogof wants to merge 1 commit into
Open
fix: Improve group parsing in asound-fix.c and handle errors gracefully#79pogof wants to merge 1 commit into
pogof wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is mainly targeted to get Exceed 1 to work for me as it rejects both
dmixanddmix:CARD=PCH,DEV=0. However it also might be part of the issue #78 ? I have no clue, just throwing it on here as draft in case someone else also has issues and wants to test.Yet to be tested.EDIT:
Exceed booted with audio when set to
patch.sound.device=dmix:CARD=PCH,DEV=0. It did not do that before, it would just crash (same with setting it to justdmixas recommended by the log file).Since this is also used by MK3 hook, more testing will have to be done with them, otherwise just Exceed is working good.
Edit 2:
Has been tested with all mk3 games and selection of other. Works as intended.