Repository navigation
Trim the public API to the simulator, its handlers and the built-in sequences - #41
Merged
Merged
Conversation
…equences Model-based reconstruction and the voxelwise least-squares fit move to bartorch (nlop.ModelOperator, apps.mobafit); the examples that use them run on bartorch. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qarafd1QwmJGNY8ZwdvwUY
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qarafd1QwmJGNY8ZwdvwUY
Contributor
Author
|
Two checks were red on the first push.
I'll re-run the HTML job after bartorch 0.0.14 is published. Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
The public surface is now
Simulator,ModelOperator,Subspace, the sequence vocabulary, the*_simwrappers,estimators(DictionaryMatcher,LookupTable,PERK) andoptim.model/,recon/,utils/,executionandoffload. Execution is chosen with anexecution=keyword.preparation,other,readoutanddelay.NonlinearLeastSquaresand the Gauss-Newton solver. Voxelwise fitting is now bartorch'sapps.mobafit, and model-based reconstruction is bartorch'snlop.ModelOperatorandnlop.IRGNM.docextra (bartorch>=0.0.14). The same applies to the model-based reconstruction figure on the explanation pages.Released before bartorch 0.0.14 and pulserver: pulserver/bartorch and pulserver/pulserver carry the matching changes. The docs build needs bartorch 0.0.14.
How it was checked
The one failure is
tests/optim/test_design.py::test_an_image_quality_design_fits_in_its_budget. It is a wall-clock budget check: its 60-iteration loop took 7.0 s against a 3 s limit while the bartorch suite was running on the same machine. Run on its own, the whole test took 3.9 s, which includes 2 warm-up iterations outside the timed loop.pre-commit run --all-filesis clean. The docs build with executed examples is in progress on the review branch.Checklist
pytest tests/passes locally, apart from the timing check described above.pre-commit run --all-filesis clean.bash scripts/build_docs.shstill builds. The build is running.🤖 Generated with Claude Code
https://claude.ai/code/session_01Qarafd1QwmJGNY8ZwdvwUY
Generated by Claude Code