Repository navigation
Show the README logo's dark variant in the documentation's dark mode - #40
Merged
Merged
Conversation
The landing page includes the README, whose <picture> chooses its variant by the operating system's colour scheme; the theme's dark mode then paints the light logo on a white panel. Rewrite it into the only-light/only-dark pair the theme switches between, and read the images from this build, as pulserver, pypulseqpp and bartorch do. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PATi8kf1N11TnfKmC4S4q3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before: on the documentation's landing page in dark mode, the blochsim logo was drawn on a white panel.
After: the dark variant of the logo appears in dark mode and the light variant in light mode, as on the pulserver, pypulseqpp and bartorch sites.
The landing page includes the README. The README's
<picture>chooses its variant by the operating system's colour scheme, not by the theme's light/dark switch. So the theme showed the light<img>and gave it a white background in dark mode.How: an
include-readhandler indocs/conf.pyrewrites the<picture>into theonly-light/only-darkimage pair that the theme switches between. It also points the image URLs at this build's_static/. This is the same handler pulserver uses.🤖 Generated with Claude Code
https://claude.ai/code/session_01PATi8kf1N11TnfKmC4S4q3
Generated by Claude Code