Repository navigation
Install pypulseq with blochsim and drop the pulseq extra - #39
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CSvVvjFeiWyziAK7m5LaLR
…-xhxvtx # Conflicts: # docs/api/sequence.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Matteo · project thread
What this changes
Before: reading a Pulseq file (
read_pulseq_description,from_pulseq) neededpip install blochsim[pulseq]. Without that extra, the call raised an ImportError naming the extra.After: pypulseq is a core dependency and the
pulseqextra is removed. The runtime extras are now onlycu12andcu13. The ImportError wrapper, itsRaisesentries and the pypulseq skip guards in the two reader test modules are removed. The docs, the description lesson's Colab cell and thetest,docandexamplesextras no longer nameblochsim[pulseq].This is part of the extras audit across the project (linked from the project thread). An extra stays only for GPL code, CUDA builds, MKL or a heavy ML stack. pypulseq is pure Python, and pypulseqpp and pulserver already require it.
How it was checked
Checklist
pytestpasses on the two modules that touch pypulseq. The full suite runs in CI. No new behaviour, so no new test.pre-commit run --all-filesis clean.Raises: ImportErrorentries are removed).🤖 Generated with Claude Code
https://claude.ai/code/session_01CSvVvjFeiWyziAK7m5LaLR
Generated by Claude Code