Repository navigation
Put FINUFFT back to choosing its own threads after a one-thread test - #151
Merged
Merged
Conversation
The one-thread fixture restored BART's count but left FINUFFT on it, so test_one_thread_count_covers_bart_and_the_transform, run later in the same process as the wheel tests do, found 4 where it expects 0. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MscKdxsmwEWWNpur8CU8hR
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Matteo · project thread
Before: the v0.0.16 wheel builds (publish.yml) failed on every platform at
test_one_thread_count_covers_bart_and_the_transform(assert 4 == 0). The_one_threadfixture added in #150 resets BART's thread count after its test but leaves FINUFFT on that count, and the wheel tests run every file serially in one process.After: the fixture also calls
_finufft.set_threads(0), which puts FINUFFT back to choosing its own count. The test change is one line, and no library code changes.How: I reproduced the failure locally by running the two tests in order in one process (1 failed). With the fix, both pass.
tests/test_apps.pyandtests/test_finufft.pyrun serially give 195 passed and 25 skipped. Lint is clean.🤖 Generated with Claude Code
https://claude.ai/code/session_01MscKdxsmwEWWNpur8CU8hR
Generated by Claude Code