Skip to content

fix: use ctx.toolchains[] subscript instead of nonexistent .get() #465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
avrabe merged 1 commit into from
May 20, 2026
Merged

fix: use ctx.toolchains[] subscript instead of nonexistent .get() #465

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion common/wasm_component_utils.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@ def validate_component_action(ctx, wasm_file, wit_file = None):
if not (hasattr(ctx.attr, "validate_wit") and ctx.attr.validate_wit):
return []

wasm_toolchain = ctx.toolchains.get("@rules_wasm_component//toolchains:wasm_tools_toolchain_type")
wasm_toolchain = ctx.toolchains["@rules_wasm_component//toolchains:wasm_tools_toolchain_type"]
if not wasm_toolchain:
return []

Expand Down
2 changes: 1 addition & 1 deletion wit/private/wit_bindgen.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ def _wit_bindgen_impl(ctx):
# Get wit-bindgen tool from appropriate toolchain
if ctx.attr.language == "go":
# Check if TinyGo toolchain is available
tinygo_toolchain = ctx.toolchains.get("@rules_wasm_component//toolchains:tinygo_toolchain_type")
tinygo_toolchain = ctx.toolchains["@rules_wasm_component//toolchains:tinygo_toolchain_type"]
if not tinygo_toolchain:
fail("TinyGo toolchain not available. Go WIT binding generation requires TinyGo toolchain.")
wit_bindgen = tinygo_toolchain.wit_bindgen_go
Expand Down
Loading