Skip to content

chore: fixed circular dependency issues within actions, utilities and api. - #366

Merged
ggainey merged 5 commits into
pulp:mainfrom
Redtigercod4:chore/fix-circular-deps
Sep 25, 2026
Merged

ggainey merged 5 commits into
pulp:mainfrom
Redtigercod4:chore/fix-circular-deps

Conversation

@Redtigercod4

@Redtigercod4 Redtigercod4 commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Addressed circular dependency issues within actions, utilities and api with a follow-up PR focusing on components. Used both madge and a new ESLint rule to detect these, which should help mitigate bugs that could otherwise only surface at runtime. The main driving force behind this work was to rule out circular dependencies as a contributing factor in the ongoing Babel 8 investigation. (#337)

Changes

  1. Ran madge --circular to uncover existing circular dependency chains primarily caused by barrel imports.
  2. Added new ESLint rule to further detect other circular dependencies not found by madge.
  3. Fixed circular dependencies within src/api.
  4. Fixed circular dependencies within src/utilities.
  5. Fixed circular dependencies within src/actions.

Out of Scope

  1. Further Babel 8 investigations following the circular dependency fixes

Blockers

N/A

Linked issue

N/A

Sources

  1. https://www.npmjs.com/package/madge
  2. Bump the babel group across 1 directory with 7 updates #337

@Redtigercod4
Redtigercod4 force-pushed the chore/fix-circular-deps branch from e18c67c to c67e242 Compare September 23, 2026 09:45
@Redtigercod4
Redtigercod4 force-pushed the chore/fix-circular-deps branch from f044a14 to 9e29de8 Compare September 23, 2026 09:49
@Redtigercod4
Redtigercod4 force-pushed the chore/fix-circular-deps branch from 9e29de8 to 6ca130d Compare September 23, 2026 19:42
@Redtigercod4
Redtigercod4 marked this pull request as ready for review September 25, 2026 08:28
@ggainey
ggainey merged commit 986ff01 into pulp:main Sep 25, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants