ci: Stop pinning the internal CI to the common-cells-v2 nonfree branch - #202
Merged
Conversation
The pin predates #80 and the per-id tracer split, so the child pipeline compiled a coverage bind with the old channel-coupler ports, an UVM top including the removed idma/tracer.svh, and no elaborate_all.tcl. Drop it and take the idma.mk default of deploy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.gitlab-ci.ymlpinnedIDMA_NONFREE_COMMITto thecommon-cells-v2branch. That branch has not moved since 2026-07-29, so the internal child pipeline built its checks against a nonfree tree that predates several landed changes.Three failures on the devel pipeline trace to this single pin:
xrun-uvm-compileandvsim-compile-cov: the coverage bind still wires the pre-Fix sending of AWs for decouple_rw without decouple_aw #80 channel-coupler ports (r_rsp_valid_i,r_rsp_ready_i,r_rsp_first_i,r_decouple_aw_i), so elaboration fails withxmelab: *E,CUVUNF.vsim-compile-cov: the UVM top still includes the removedidma/tracer.svh, soIDMA_TRACER_RW_AXIis undefined after the per-id tracer split (ci: Verify the backend variants publicly with verilator and slang #186).jasper-elaborate:elaborate_all.tcldoes not exist on that branch.Dropping the pin takes the
idma.mkdefault ofdeploy, which carries all three fixes.The
initjob was unaffected because the project-level CI/CD variableIDMA_NONFREE_COMMIT=deploywins there; only the child pipeline inherited the stale YAML value, which is why the generatedci.ymllooked current while the jobs consuming it did not.