fix: Drive usage_o low if not supported - #357
Open
gbellocchi wants to merge 1 commit into
Open
Conversation
The `cc_stream_fifo_optimal_wrap` originally assigned an unknown state to `usage_o` when `Depth == 32'd2`. This fix simply defines the signal state and drives it low if not supported. The specific value of `usage_o` should not be problematic in this case since the port is generally not connected when instantiated at a higher hierachy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
This PR includes a solution for issue #356. The
cc_stream_fifo_optimal_wraporiginally assigned an unknown state tousage_owhenDepth == 32'd2. This issue was first found when running Spyglass checks into thesnitch_cluster(PR #330).Solution
This fix simply defines the signal state and drives it low if not supported. The specific value of
usage_oshould not be problematic in this case since the port is generally not connected when instantiated at a higher hierachy.