test: isolate story arc catalog database sessions - #162
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Correct only the two Story Arc catalog test database fixtures that blocked the
v2.0 edge qualification. Provider cache/account sessions must not share one
in-memory SQLite connection with the request session: invalidating one peer
could close the request connection and discard its database.
Each owning suite now uses its own disposable file-backed SQLite database outside
the comic-library test directory. Engines are disposed in fixture cleanup.
No production runtime, provider timeout, import/recovery, deletion, file-safety,
UI behavior, or release gate changes are included.
Validation
no active connectionfailurebefore the correction; both now pass.
authentication, source-failure, and source-file assertions.
make ci-fullpasses: 15,977 non-browser tests with PostgreSQL,91.58% coverage, 26 accessibility tests, 662 tests in each browser (2 skips
each), blocking container scanning, and 7 Docker smoke tests.
initially timed out in one daily-sync case on Python 3.13 before its mock
provider call. All 64 owning SQLite/PostgreSQL cases pass unchanged locally;
the failed lane passed on one unchanged retry. Python 3.12/3.14 also passed;
Chromium/Firefox qualification is running. No change was made for that timeout.
After all gates pass, merge to develop and qualify the exact merge SHA before
publishing the 2.0.0-dev edge preview. Stable release tags are unchanged.