Skip to content

test: isolate story arc catalog database sessions - #162

Merged
DeusExTaco merged 1 commit into
developfrom
feature/v2-edge-qualification-fixtures
Oct 2, 2026
Merged

DeusExTaco merged 1 commit into
developfrom
feature/v2-edge-qualification-fixtures

Conversation

@DeusExTaco

@DeusExTaco DeusExTaco commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Correct only the two Story Arc catalog test database fixtures that blocked the
v2.0 edge qualification. Provider cache/account sessions must not share one
in-memory SQLite connection with the request session: invalidating one peer
could close the request connection and discard its database.

Each owning suite now uses its own disposable file-backed SQLite database outside
the comic-library test directory. Engines are disposed in fixture cleanup.
No production runtime, provider timeout, import/recovery, deletion, file-safety,
UI behavior, or release gate changes are included.

Validation

  • Two deterministic regressions reproduced the CI no active connection failure
    before the correction; both now pass.
  • All 64 owning API/UI cases pass, preserving stale-decision, partial-add,
    authentication, source-failure, and source-file assertions.
  • Normal commit hooks pass and the worktree is clean.
  • Full local make ci-full passes: 15,977 non-browser tests with PostgreSQL,
    91.58% coverage, 26 accessibility tests, 662 tests in each browser (2 skips
    each), blocking container scanning, and 7 Docker smoke tests.
  • Security, Docker validation, and workflow hygiene are green. Exact-head CI
    initially timed out in one daily-sync case on Python 3.13 before its mock
    provider call. All 64 owning SQLite/PostgreSQL cases pass unchanged locally;
    the failed lane passed on one unchanged retry. Python 3.12/3.14 also passed;
    Chromium/Firefox qualification is running. No change was made for that timeout.

After all gates pass, merge to develop and qualify the exact merge SHA before
publishing the 2.0.0-dev edge preview. Stable release tags are unchanged.

@DeusExTaco DeusExTaco added the ci:full Run the full CircleCI PR gate label Oct 2, 2026
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-02T04:42:17.781921Z 7425d7a PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@DeusExTaco
DeusExTaco merged commit cc36afe into develop Oct 2, 2026
39 of 67 checks passed
@DeusExTaco
DeusExTaco deleted the feature/v2-edge-qualification-fixtures branch October 2, 2026 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:full Run the full CircleCI PR gate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant