live: fix missing power icons (doubled _power suffix)#552
Open
ptrlrd wants to merge 1 commit into
Open
Conversation
…suffix
Power ids from the mod already include _POWER (e.g. DEXTERITY_POWER, WEAK_POWER)
and the asset is dexterity_power.png. PowerRow appended an extra _power, building
dexterity_power_power.png -> 404, so the combat scene showed power amounts with
no icons. Use {id}.png (verified: dexterity_power.png is 200, the doubled form is
404).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On the live battle scene, player/enemy powers showed their amount but no icon. The mod's power ids already end in
_POWER(e.g.DEXTERITY_POWER) and the asset isdexterity_power.png, butPowerRowappended an extra_power, buildingdexterity_power_power.png-> 404. Drops the extra suffix ({id}.png). Verified against the CDN:dexterity_power.png/vulnerable_power.png/weak_power.pngare 200, the doubled form 404s.