[ptr727]

Summary

Implements #3458 (the closing keyword goes on the promotion pull request).

• The whole wait body moves out of main into run_wait(owner, repo, a), unchanged, so main is parsing and dispatch.
• Flag ownership is read from FLAG_OWNERS, one row of (flag, owners, late) per flag, checked in two passes around the cleanup and number checks so a command line with several bad flags names the same one first. Listing cleanup among --checkout's owners lets the error text be the owners joined, and the cleanup check right after it still refuses that command.
• The four negative-value checks are one loop.
• COMMANDS is the parser's choices, and the owner test reads it.

Verification

• The first error line and the exit of 1904 bad command lines, every subcommand crossed with pairs of misplaced, negative, and malformed flags, were recorded before and after with every subprocess stubbed out, and are identical.
• test_a_command_line_with_two_bad_flags_names_the_same_one_first pins six multi-flag orderings, and passes against the pre-change code as well.
• The full suite passes, python -m unittest discover -s tests, 2965 tests, 7 skipped. Ruff, mypy, and the pre-commit hook are clean.
• A local strict review ran two rounds on the first push. Round 1 raised three introduced findings, each fixed in d145242d. Round 2 raised one, COMMANDS landing between the FLAG_OWNERS comment and the table, which the second push fixed in 2ca2e75d. Its own pass raised none.

Pre-existing findings, filed

• --timeout, --min-rounds, and --ignore-quota-signal are still accepted silently on subcommands other than wait: Refuse the Wait-Only Flags on Other pr_review Subcommands #3496.

The comments label is applied for the new table and loop comments.

🤖 Generated with Claude Code

[coderabbitai]

Important

• 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

• Source mode: Auto
• Repository: ptr727/ProjectTemplate
• Branch: wait-out-of-main
• File: .coderabbit.yaml
• Commit: 2ca2e75
• Layers: Repository YAML
• Review profile: CHILL
• Plan: Advanced
• Run ID: eee2ef30-eae9-4824-a8b8-294e3b5230ed

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[ptr727]

A recorded local strict-review pass covers head 2ca2e75de4fb4b45ba8ad9ead78b627523ae2e6e, the content this pull request carries at that commit against develop, and it recorded 0 findings.

[Copilot]

🟡 Changes recommended

The unresolved review comment requests moving COMMANDS outside the FLAG_OWNERS comment block to correct the table documentation.

1 open issue

• Move COMMANDS outside the FLAG_OWNERS comment block · New

What changed in this PR

This pull request refactors pr_review.py to separate argument parsing and dispatch from the wait workflow while preserving CLI behavior and validation order.

Changes:

• Moves the wait implementation into run_wait.
• Centralizes command and flag ownership validation in tables.
• Consolidates negative-value checks.
• Adds regression tests for flag validation order and ownership metadata.
• Requires moving COMMANDS outside the FLAG_OWNERS comment block so the table is accurately documented.

File	Summary
tests/​test_pr_review.py	Adds regression coverage for multi-flag error ordering and ownership-table integrity.
scripts/​pr_review.py	Extracts run_wait and introduces table-driven command and flag validation.

_{Review effort: Lite}

[codecov]

Codecov Report

❌ Patch coverage is 98.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 81.07%. Comparing base (fb485f6) to head (2ca2e75).

Files with missing lines	Patch %	Lines
scripts/pr_review.py	98.66%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #3497      +/-   ##
===========================================
- Coverage    81.07%   81.07%   -0.01%     
===========================================
  Files           26       26              
  Lines         8934     8928       -6     
===========================================
- Hits          7243     7238       -5     
+ Misses        1691     1690       -1     

Flag	Coverage Δ
python-3.13	81.07% <98.66%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.