Skip to content

Restore the Caveat That a Review-Present Exit 0 Does Not Poll the Checks #3491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ptr727 merged 3 commits into from
Oct 25, 2026
Merged

Restore the Caveat That a Review-Present Exit 0 Does Not Poll the Checks #3491

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b15f286
Restore the Caveat That a Review-Present Exit 0 Reads No Check
ptr727 Oct 25, 2026
45e6d71
Say a Review-Present Exit 0 Does Not Poll the Checks
ptr727 Oct 25, 2026
8c65e4d
Place the Review-Present Caveat Before the Held-Head Sentences
ptr727 Oct 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scripts/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,7 @@ uv run --no-project --script scripts/pr_review.py cleanup 452 --repo ptr727/Proj

| Code | Command | Meaning |
| --- | --- | --- |
| `0` | `status`, `wait` | No Copilot review covers the head yet (`status`), or the review covering it states no partial coverage and its verdict counts what it flags. On a held head, an attested local pass whose checks no longer hold the poll, short of `45`. |
| `0` | `status`, `wait` | No Copilot review covers the head yet (`status`), or the review covering it states no partial coverage and its verdict counts what it flags. On a held head, an attested local pass whose checks no longer hold the poll, short of `45`. Exit `0` on that review does not poll the checks, so it does not prove the required checks ran. |
| `30` | `wait` | Still pending at the timeout, which is pending rather than failed. On a held head, `status=CHECKS_PENDING`. A round past `--min-rounds` not yet landed. |
| `40` | `wait` | No Copilot review covers the head: the reviewer answered outside a formal review, the request returned success and recorded nothing, or the reviewer writes under a login no query filters on. |
| `41` | `wait` | The newest round is a refusal or a quota state, its kind printed in the status line, and in `refusal=` for a refusal on this pull request. |
Expand Down
5 changes: 3 additions & 2 deletions scripts/pr_review.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,8 +114,9 @@
carries any Copilot activity. The loop runs in-process, so a 45-minute wait costs one
agent turn, not 90.
Exit 0 = review present, or on a held head an attested local pass whose checks no longer
hold the poll. On an open pull request whose head commit the payload carries, every
workflow run the read reaches on that head has then completed. The read reaches the
hold the poll. Exit 0 on a review present does not poll the checks, so it does not prove
the required checks ran. On an open attested held head whose commit the payload carries,
every workflow run the read reaches on that head has then completed. The read reaches the
head's last 50 check suites and those of its first CHECKS_WINDOW rollup contexts. A
CLEAN, UNSTABLE, or HAS_HOOKS merge owes no required check. Under any other merge, an
open attested held head nothing holds exits 45 where its rollup was unreadable or, under
Expand Down
Loading