[ptr727]

Summary

Answers #3436. cleanup_remote_delete read the ref back once, right after deleteRef. GitHub's ref read can lag a delete that landed, so a landed delete could print status=DELETE_NOT_CONFIRMED and exit 2 before the local half ran.

• A ref still at the deleted tip is now read again on DELETE_SETTLE_DELAYS = (1, 2, 4) through the existing core.backoff helper, so about seven seconds at most, before it is reported. Exit 2 still follows once that schedule is spent.
• A read back at a tip other than the deleted one stops the loop and gets its own message ("a tip other than the one deleted, so something pushed to the branch"), since re-reading it settles nothing.
• scripts/README.md's cleanup paragraph says so.
• Tests: a read lagging then gone settles to DELETED and exit 0. A ref present on every read exits 2 after exactly the scheduled reads. A settle read that does not answer exits 2. A new tip stops the loop and names that tip. The first two fail against the unfixed source. The existing suite patches the schedule to (), which reproduces the old single read.

Known limits, not defects

• A branch pushed back at the deleted tip inside the settle window cannot be told from lag. It ends still reads at <tip> after the delete, exit 2, which is the conservative outcome.
• scripts/handoff.py reads state back once after a write in create_label, close, and edit_issue. No lag has been seen on label or issue reads, so these are the sites to name in one issue only if it is.

Verification

• Full suite: uv run --no-project --with-requirements tests/requirements.txt python -m unittest discover -s tests, 2952 tests run, OK (7 skipped), at 278e49a. The commit after it changes message wording and a test name, and test_pr_*.py (628 tests) passes on it.
• Local strict review: three passes. Round 1 raised three introduced findings (a README sentence over the length limit, no test for a settle read that does not answer, and the loop re-reading a ref at a new tip), all fixed in 278e49a. Round 2 raised three (an overclaiming message, a stale docstring, a long line), fixed in 2c71411. The third pass raised none.

Pre-existing findings, not filed

• scripts/README.md:264, pre-existing: five sentences this change did not edit run over the 25-word sentence-length check.

🤖 Generated with Claude Code

[ptr727]

A recorded local strict-review pass covers head 2c71411c1f2760a4064deddcdb56bc88a2594a07, the content this pull request carries at that commit against develop, and it recorded 0 findings.

[coderabbitai]

Important

• 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

• Source mode: Auto
• Repository: ptr727/ProjectTemplate
• Branch: fix/cleanup-reread-deleted-ref
• File: .coderabbit.yaml
• Commit: 2c71411
• Layers: Repository YAML
• Review profile: CHILL
• Plan: Advanced
• Run ID: 7daeebb1-7b41-4a4e-b676-cc3ea772a18b

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[Copilot]

🟢 Approval recommended

The reviewed changes have no unresolved blocking issues and include focused test coverage and documentation.

No open issues 🎉

What changed in this PR

This pull request improves remote branch deletion confirmation by retrying ref reads when GitHub’s response may lag after a successful deletion.

Changes:

• Adds bounded confirmation retries using the existing backoff helper.
• Distinguishes deleted refs, unreadable reads, and refs moved to a new tip.
• Adds focused tests and documents the retry behavior.

File	Description
tests/​test_pr_cleanup.py	Tests delayed deletion visibility, exhausted retries, unreadable reads, and changed tips.
scripts/​README.md	Documents eventual-consistency handling during remote deletion.
scripts/​pr_cleanup.py	Implements bounded ref-confirmation retries and new-tip reporting.

_{Review effort: Lite}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (develop@5f5ea25). Learn more about missing BASE report.

Additional details and impacted files

@@            Coverage Diff             @@
##             develop    #3480   +/-   ##
==========================================
  Coverage           ?   81.00%           
==========================================
  Files              ?       25           
  Lines              ?     8902           
  Branches           ?        0           
==========================================
  Hits               ?     7211           
  Misses             ?     1691           
  Partials           ?        0           

Flag	Coverage Δ
python-3.13	81.00% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.