Repository navigation
Prove Paths Are Not Words in the Vocabulary Check - #3478
Merged
Merged
Conversation
The is_word docstring says a path with a separator is not a word, and no case held one. Six slash paths that would read as words without their separator, and a backslash path, now sit in the case covering flags and underscored names. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
One backslash path among six slash paths could not cross the cap by itself, so a pattern accepting backslashes alone would pass. Six of each now sit in a tuple apiece. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
 |
Owner
Author
|
A recorded local strict-review pass covers head |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The reviewed change has no unresolved findings and all approval assessments support approval.
No open issues 🎉
What changed in this PR
This pull request strengthens vocabulary-check regression coverage by verifying that both POSIX-style and Windows-style paths are not counted as words.
Changes:
- Renames the test to include path coverage.
- Adds six slash-separated and six backslash-separated paths.
- Preserves existing flag and underscored-name coverage.
| File | Description |
|---|---|
tests/test_prose_lint.py |
Extends the vocabulary-check regression test with POSIX and Windows path examples. |
Review effort: Lite
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #3478 +/- ##
========================================
Coverage 80.98% 80.98%
========================================
Files 25 25
Lines 8895 8895
========================================
Hits 7204 7204
Misses 1691 1691
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ptr727
added a commit
that referenced
this pull request
Oct 25, 2026
…3476) ## Summary Promotes the pull requests merged into develop since release 2.0.1178. - [#3474](#3474): replaces the prose gate's line ceiling with a test that fails where `prose_lint.py` holds a banned spelling, an exemption entry, or a collection literal of more than five words. - [#3477](#3477): answers this promotion's review. The `is_word` docstring now says what its pattern accepts, and a word tuple keying a mapping beside a wordless value is reported. - [#3478](#3478): answers this promotion's second review round, a case proving paths with a `/` or `\` separator are not words. Closes #3441 ## Constituent coverage Each change this promotion carries had coverage on its own pull request into develop, at its merged head: | Pull request | Merged head | Coverage | | --- | --- | --- | | [#3474](#3474) | `9d631289` | attested local pass at the merged head, base `develop`, and a Copilot table on the merged head naming exactly its one changed file, no open findings | | [#3477](#3477) | `0999fc81` | attested local pass at the merged head, base `develop`, and a Copilot table on the merged head naming exactly its one changed file, no open findings | | [#3478](#3478) | `93ba9d90` | attested local pass at the merged head, base `develop`, and a Copilot table on the merged head naming exactly its one changed file, no open findings | 🤖 Generated with [Claude Code](https://claude.com/claude-code)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Answers the second-round finding promotion #3476 raised on the vocabulary check: the
is_worddocstring says a path with a separator is not a word, and no case held a path. The case covering flags and underscored names, renamedtest_flags_paths_and_underscored_names_are_not_words, now carries six slash paths and six backslash paths in a tuple apiece, so a pattern accepting either separator pushes its tuple past the five-word cap.Verification
tests/test_prose_lint.py: 629 tests, OK. ruff and mypy clean.prose_lint.py --diffagainst the merge base, with and without--check sentence-length: clean./replaced by a space in the case's source, it reportsPATHSat 6 words, and with\replaced,WINDOWSat 6 words.🤖 Generated with Claude Code