Converge governance docs: Durable Knowledge section + review guidance#891
Merged
Conversation
Re-vendor the verbatim AGENTS.md sections from hub main, which adds the new Durable Knowledge and Self-Improvement section (after Foundational Principles) and drops three residual catalog-snippet paths from the Branching Model, Documentation Style Conventions, and Editor and Tasks sections. All 16 verbatim sections byte-match the canonical, with zero relative links to hub-only paths. Add the Reviewing Carried Fleet Content section to .github/copilot-instructions.md (carried byte-for-byte from the canonical): it tells the review layer that references inside byte-locked verbatim text to paths a repo does not carry are intentional, not broken links - the fix for the recurring false-positive class from the last review rounds. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR re-vendors and aligns PlexCleaner’s governance/reviewer guidance with the current hub canonical, reducing drift and preventing recurring false positives when reviewing byte-locked carried content.
Changes:
- Add the “Durable Knowledge and Self-Improvement” section to
AGENTS.md. - Remove stale references to hub-only catalog snippet paths from
AGENTS.md. - Add “Reviewing Carried Fleet Content” guidance to
.github/copilot-instructions.mdto clarify how to treat intentional references inside byte-locked sections.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
AGENTS.md |
Adds Durable Knowledge guidance and removes stale hub-only catalog snippet references to keep carried governance text current. |
.github/copilot-instructions.md |
Adds reviewer guidance for carried/byte-locked fleet content to reduce false-positive review findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 1 of the hub's convergence-to-zero plan on #880 (self-contained doc re-vendor; no divergence work). Re-derived against hub
main@2a178f0.AGENTS.md
Re-vendored all 16 verbatim sections from the current hub
main, which in one pass:## Durable Knowledge and Self-Improvement(new verbatim section, after Foundational Principles).run-codegenworkflow path, Documentation Style Conventions'catalog/snippets/workflows/*parenthetical, Editor and Tasks'catalog/snippets/vscode/sentence).All 16 verbatim sections verified byte-identical to the canonical via the audit's own extract + EOL/action-pin normalization. Zero relative links to hub-only paths remain. Devcontainer and Repository Layout stay as this repo's intent sections; Repository Onboarding and Conformance stays out (hub-only).
.github/copilot-instructions.md
Adds
## Reviewing Carried Fleet Content(carried byte-for-byte from the canonical, after Commit Messages and Pull Request Titles). This is the fix for the recurring false-positive class from the last review rounds - it tells the review layer that a reference inside byte-locked verbatim text to a path this repo does not carry is intentional, not a broken link, while still inviting genuine substantive findings (routed upstream). The file is intent-fidelity, so only the heading is audit-checked, but the full text is carried so the section does its job.Verification
16 verbatim sections byte-identical to hub
main; copilot-instructions section byte-identical to the canonical; 0 broken relative links. markdownlint-cli2, editorconfig-checker, cspell (README/HISTORY), husky pre-commit gate all clean. ASCII + CRLF verified. No C# changed.