Repository navigation
Musl build 04 conditionals - #4673
Open
peppergrayxyz wants to merge 20 commits into
Open
peppergrayxyz wants to merge 20 commits into
peppergrayxyz wants to merge 20 commits into
Conversation
peppergrayxyz
force-pushed
the
musl_build_04_conditionals
branch
2 times, most recently
from
November 10, 2026 10:38
8a0d530 to
60f60e3
Compare
Owner
|
And you need to rebase now |
Signed-off-by: Pepper Gray <hello@peppergray.xyz>
Signed-off-by: Pepper Gray <hello@peppergray.xyz>
Signed-off-by: Pepper Gray <hello@peppergray.xyz>
Signed-off-by: Pepper Gray <hello@peppergray.xyz>
Signed-off-by: Pepper Gray <hello@peppergray.xyz>
Signed-off-by: Pepper Gray <hello@peppergray.xyz>
my32_pthread_mutex_init: fake->i386__kind: incomplete definition of type 'struct __pthread_mutex_s' Signed-off-by: Pepper Gray <hello@peppergray.xyz>
Signed-off-by: Pepper Gray <hello@peppergray.xyz>
Signed-off-by: Pepper Gray <hello@peppergray.xyz>
Signed-off-by: Pepper Gray <hello@peppergray.xyz>
Signed-off-by: Pepper Gray <hello@peppergray.xyz>
Signed-off-by: Pepper Gray <hello@peppergray.xyz>
Signed-off-by: Pepper Gray <hello@peppergray.xyz>
Signed-off-by: Pepper Gray <hello@peppergray.xyz>
Signed-off-by: Pepper Gray <hello@peppergray.xyz>
Signed-off-by: Pepper Gray <hello@peppergray.xyz>
Signed-off-by: Pepper Gray <hello@peppergray.xyz>
Signed-off-by: Pepper Gray <hello@peppergray.xyz>
Signed-off-by: Pepper Gray <hello@peppergray.xyz>
Signed-off-by: Pepper Gray <hello@peppergray.xyz>
peppergrayxyz
force-pushed
the
musl_build_04_conditionals
branch
from
November 12, 2026 10:41
60f60e3 to
e9d0d5c
Compare
ptitSeb
reviewed
Nov 12, 2026
|
|
||
| include(CheckIncludeFile) | ||
|
|
||
| set(PROJECT_HEADERS |
Owner
There was a problem hiding this comment.
Maybe all those checks should go in another file and just include it here?
Collaborator
There was a problem hiding this comment.
second this. also is it necessary to enable these checks for non-musl targets?
ptitSeb
approved these changes
Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #4580