test(ios): eliminate Swift concurrency warnings (#154) - #164
Conversation
Run the doctor-command assertion on the main actor and keep mutable settlement state in the existing actor- isolated test recorder. This removes the Xcode 26.6 warnings without changing app runtime code or the asserted transition. What could go wrong and why this is safe: moving test state could weaken the settlement-transition coverage. The test still proves the same true-to-false transition, the complete 497-test plan and focused 14-test run pass, and the build result contains zero warnings. Fixes #154
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 2 included reviews per hour; 0 remain after this review. 📜 Recent review details⏰ Context from checks skipped due to timeout. (5)
🧰 Additional context used📓 Path-based instructions (4)Focus on Swift 6 strict concurrency, Sendable/MainActor correctness, Task cancellation,⚙️ CodeRabbit configuration file Files:
VaultSync syncs private Obsidian notes through Syncthing. Treat data loss,⚙️ CodeRabbit configuration file Files:
Build the iOS/iPadOS application with Swift 6 and SwiftUI, targeting iOS/iPadOS 18 or later.📄 CodeRabbit inference engine (README.md) Files:
For Swift background execution changes, pass if work is bounded, cancellation-aware, handles expiration callbacks, and records errors without leaking private vault data. Fail only when background work can continue unbounded, miss cleanup, o...📄 CodeRabbit inference engine (Custom checks) Files:
🔇 Additional comments (3)
📝 WalkthroughWalkthroughThe changes update two iOS tests. One test gains main-actor isolation. Another moves mutable settlement state into its recorder helper. Both test names reference issue ChangesiOS test concurrency cleanup
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to This change removes Swift concurrency warnings from iOS tests while preserving the tested behavior, with no actionable merge-blocking risk remaining after normal checks and review. Poem
🚥 Pre-merge checks | ✅ 7✅ Passed checks (7 passed)
Full details: Linked Issues checkExplanation The changes address issue Full details: No Private Note LeakageExplanation PASS — The diff only adds test annotations, issue references, and the in-memory Full details: Bounded Ios Background WorkExplanation PASS: The pull request changes only two iOS test files. The diff adds Full details: Bridge Contract CompatibilityExplanation PASS — The check is not applicable to this pull request. The commit changes only two Swift test files. The changes add ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
1 participant
Run the doctor-command assertion on the main actor and move mutable settlement state into the existing
actor-isolated test recorder. This removes the two Xcode 26.6 warnings without touching product code or changing
the tested behavior.
Verification:
This is issue-level evidence only. The exact 2.0.2 candidate and its rebuilt XCFramework do not yet exist.
Fixes #154
Summary
Verification