don't omit CRLF when those are the only bytes the in the chunk - #469
Open
ogalland-tob wants to merge 1 commit into
Open
don't omit CRLF when those are the only bytes the in the chunk#469ogalland-tob wants to merge 1 commit into
ogalland-tob wants to merge 1 commit into
Conversation
woodruffw
approved these changes
Aug 29, 2026
woodruffw
left a comment
woodruffw
left a comment
Member
There was a problem hiding this comment.
Thanks @ogalland-tob!
Making sure I understand: this happens when we're reading chunks of an HTTP response, and previously we'd accidentally discard a CRLF if it happened to be the only contents of a chunk?
Contributor
Author
|
Yes, this would cause chunks made up entirely of CRLF to be dropped. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CallbackFileWrapper._safe_read()omits a legitimate two-byte CRLF chunk from the cached response body. If a response contains a chunk consisting exclusively of CRLF, it is omitted from the cached response.This PR fixes the issue by keeping track of remaining bytes in
CallbackFileWrapperand only omitting the trailing CRLF. It also introduces a relevant unit test.