don't lower case-sensitive user info embedded in URLs - #466
Open
ogalland-tob wants to merge 2 commits into
Open
Conversation
woodruffw
reviewed
Aug 29, 2026
|
|
||
| scheme = scheme.lower() | ||
| authority = authority.lower() | ||
| userinfo, separator, host = authority.rpartition("@") |
Member
There was a problem hiding this comment.
I'm a little worried about this being conformant -- does RFC 3986 or similar guarantee that partitioning on the last @ is correct?
Contributor
Author
There was a problem hiding this comment.
Good point, I was assuming there could only be one @ in the authority, but I haven't checked against the RFC. Will take a look now.
Contributor
Author
There was a problem hiding this comment.
As per RFC 3986, authority = [ userinfo "@" ] host [ ":" port ]. afaiu @ is excluded from all of these symbols. The @ character is only included in gen-delims, which does not show up in any of userinfo, host, port.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CacheControl lowercases URL user information when constructing cache keys. Requests preserves its case and generates different Basic Authorization headers, allowing a response for one credential spelling to satisfy another.
This PR prevents the lowering of userinfo in URL and introduces a unit test for this case.