Repository navigation
Tool hub: route NVIDIA SkillSpector through review_checks.sh - #2378
Merged
Merged
Conversation
Adds skillspector (changed SKILL.md files, one per run, `--no-llm` static analysis, SARIF written to a file). NOT CHECKED when missing; not run on a crash, empty or wrong-shape output, or a non-zero exit with no row. Cisco mcp-scanner is documented as not routed: its raw output schema and the offline behavior of config scans are not documented, so no row was added. Sources (fetched 2026-11-14): https://github.com/NVIDIA/skillspector (Apache-2.0, tag v2.13.4), https://github.com/cisco-ai-defense/mcp-scanner (Apache-2.0, tag 4.8.7). Unverified: skillspector SARIF location shape and single-file SARIF via -o; mcp-scanner raw schema and offline config scan. Tests: 21/21 hub-pmd-solhint, 9/9 hub-skillspector (new), tool-hub, hub-lang, hub-kd, provision-tools 0 FAIL; test-ci-gates 303 pass / 9 fail (not attributed to this change, sandbox blocks github.com) size-budget-raise: .claude/skills/deep-code-review/references/tool-hub.md 59805→61157 hub rows for skillspector and mcp-scanner with verification evidence Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds skillspector (changed SKILL.md files, one per run,
--no-llmstatic analysis, SARIF written to a file). NOT CHECKED when missing; not run on a crash, empty or wrong-shape output, or a non-zero exit with no row. Cisco mcp-scanner is documented as not routed: its raw output schema and the offline behavior of config scans are not documented, so no row was added.Sources (fetched 2026-11-14): https://github.com/NVIDIA/skillspector (Apache-2.0, tag v2.13.4), https://github.com/cisco-ai-defense/mcp-scanner (Apache-2.0, tag 4.8.7).
Unverified: skillspector SARIF location shape and single-file SARIF via -o; mcp-scanner raw schema and offline config scan.
Tests: 21/21 hub-pmd-solhint, 9/9 hub-skillspector (new), tool-hub, hub-lang, hub-kd, provision-tools 0 FAIL; test-ci-gates 303 pass / 9 fail (not attributed to this change, sandbox blocks github.com)
size-budget-raise: .claude/skills/deep-code-review/references/tool-hub.md 59805→61157 hub rows for skillspector and mcp-scanner with verification evidence
🤖 Generated with Claude Code