Skip to content

fix: remove invalid module field#18

Closed
rupayon123 wants to merge 1 commit into
promplate:mainfrom
rupayon123:fix/remove-invalid-module-field
Closed

fix: remove invalid module field#18
rupayon123 wants to merge 1 commit into
promplate:mainfrom
rupayon123:fix/remove-invalid-module-field

Conversation

@rupayon123

Copy link
Copy Markdown

Fixes #16

The package currently builds CommonJS output only, so module points at the same CommonJS file as main. This removes the module field so bundlers do not treat dist/index.js as an ES module entry.

Checks:

  • git diff --check
  • node -e 'JSON.parse(require("fs").readFileSync("package.json", "utf8")); console.log("package.json ok")'

@bolt-new-by-stackblitz

Copy link
Copy Markdown

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@vercel

vercel Bot commented Jun 13, 2026

Copy link
Copy Markdown

@rupayon123 is attempting to deploy a commit to the promplate Team on Vercel.

A member of the Team first needs to authorize it.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the "module" field from package.json, which previously pointed to "dist/index.js". There are no review comments, and I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@coderabbitai

coderabbitai Bot commented Jun 13, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 3f20a8c8-fb05-4815-b9f7-996d45c9ae2b

📥 Commits

Reviewing files that changed from the base of the PR and between 86fd4bc and e7a37f9.

📒 Files selected for processing (1)
  • package.json
💤 Files with no reviewable changes (1)
  • package.json

📝 Walkthrough

Removed the top-level module entry from package.json so package metadata now reflects the CommonJS-only build output and consumers fall back to main instead of treating dist/index.js as ESM.

Walkthrough

This change updates package publishing metadata by removing the top-level module field from package.json. The package continues to declare its entry points through the existing main, types, and unchanged exports configuration.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately and concisely describes removing the invalid package.json module field.
Description check ✅ Passed The description matches the change and explains why removing the module field is needed.
Linked Issues check ✅ Passed The change fulfills issue #16 by removing module so consumers fall back to the CommonJS main entry.
Out of Scope Changes check ✅ Passed No unrelated changes are present; the PR only updates package metadata as required.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new

pkg-pr-new Bot commented Jun 14, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/partial-json@18

commit: e7a37f9

Copy link
Copy Markdown
Author

Closing this in favor of #21, which is the cleaner current version of the same package entry fix.

@rupayon123 rupayon123 closed this Jun 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

package.json "module" field points at a CommonJS file

1 participant