Repository navigation
fix: reject units in StateSet builder - #2635
Open
2748109647 wants to merge 1 commit into
Open
2748109647 wants to merge 1 commit into
2748109647 wants to merge 1 commit into
Conversation
Signed-off-by: Alpha <2748109647@qq.com>
2748109647
requested review from
dhoard,
fstab,
jaydeluca and
zeitlinger
as code owners
November 2, 2026 05:26
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@fstab
Fixes #2632.
StateSet.Builderinherited the genericunit(...)setter, so it accepted a non-null unit while building and only failed later duringcollect(). Override the setter to reject non-null units immediately, consistent withInfo.Builder, and add a regression test.Validation:
mvnw.cmd test -pl prometheus-metrics-core -am -Dtest=StateSetTest -Dsurefire.failIfNoSpecifiedTests=false -Dcoverage.skip=true— 5 tests passed; reactor build succeeded.mvnw.cmd install -DskipTests -DskipITs -Dcoverage.skip=true— all 56 modules built successfully.mise run lint:fixapplied formatting. Checkstyle could not run locally because its downloaded Windows executable reported an incompatible binary.docker.mirrors.ustc.edu.cnregistry mirror did not resolve when pullingtestcontainers/ryuk:0.12.0; those checks remain unverified.