chore: move narrowly-used test deps out of root pom#2146
Open
jaydeluca wants to merge 1 commit into
Open
Conversation
junit-pioneer, awaitility, wiremock, and guava (test scope) were declared in the root pom.xml, adding them to the classpath of all 24 core modules. Each is only needed by 1–3 modules: - junit-pioneer: prometheus-metrics-config (SetSystemProperty) - awaitility: prometheus-metrics-core + prometheus-metrics-exporter-opentelemetry - wiremock: prometheus-metrics-exporter-opentelemetry (ExemplarTest) - guava: prometheus-metrics-core, prometheus-metrics-exporter-opentelemetry, integration-tests/it-exporter/it-exporter-test Add version properties for junit-pioneer, awaitility, and wiremock to the root pom (guava.version already existed). Remove the four deps from root <dependencies> and add them only in the modules that actually use them. The shaded opentelemetry module also receives the same test deps since it copies and compiles the same test sources. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Jay DeLuca <jaydeluca4@gmail.com>
jaydeluca
force-pushed
the
chore/move-niche-test-deps-out-of-root-pom
branch
from
f5d8403 to
ae2b84f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The root
pom.xmlwas declaringjunit-pioneer,awaitility,wiremock, andguava(test scope) as global test dependencies, adding them to the classpath of all 24 core modules. Each is only actually needed by 1–3 modules.