Skip to content

Resolve clang-format drift in tracked source and generated icon header - #6

Closed
prokrypt with Copilot wants to merge 2 commits into
developmentfrom
copilot/fix-clang-format-job-again
Closed

prokrypt with Copilot wants to merge 2 commits into
developmentfrom
copilot/fix-clang-format-job-again

Conversation

Copilot AI commented Sep 20, 2026 •

Copy link
Copy Markdown

The clang-format Actions job was failing because the repository no longer matched the formatter output expected by CI. This change brings the tracked files back into alignment with the LLVM 21 formatting rules used in the workflow.

  • CI failure cause

    • The workflow install step was healthy; the failure came from ./bin/clang-format-fix rewriting tracked files and leaving a non-empty diff.
  • Formatting updates

    • Applied clang-format output to the affected C++ sources and tests:
      • lib/Epub/Epub/ReferencePageNavigation.h
      • src/SettingsList.h
      • src/activities/boot_sleep/SleepActivity.cpp
      • src/activities/reader/EpubReaderActivity.cpp
      • test/stable_page_navigation/StablePageNavigationTest.cpp
    • Changes are limited to line wrapping, indentation, and expression layout.
  • Generated asset consistency

    • Regenerated src/components/icons/keyboardIcons.h from src/components/icons/keyboardIcons.manifest so the checked-in generated header matches current formatter output instead of editing generated content by hand.
PATH="/usr/lib/llvm-21/bin:$PATH" ./bin/clang-format-fix
git diff --exit-code

Co-authored-by: prokrypt <1832555+prokrypt@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix failing GitHub Actions job clang-format Resolve clang-format drift in tracked source and generated icon header Sep 20, 2026
Copilot AI requested a review from prokrypt September 20, 2026 19:45
@prokrypt
prokrypt marked this pull request as ready for review September 20, 2026 19:48
@prokrypt prokrypt closed this Sep 21, 2026
@prokrypt
prokrypt deleted the copilot/fix-clang-format-job-again branch September 21, 2026 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants