Conversation
Co-authored-by: prokrypt <1832555+prokrypt@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions job clang-format
Resolve clang-format drift in tracked source and generated icon header
Sep 20, 2026
prokrypt
marked this pull request as ready for review
September 20, 2026 19:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
clang-formatActions job was failing because the repository no longer matched the formatter output expected by CI. This change brings the tracked files back into alignment with the LLVM 21 formatting rules used in the workflow.CI failure cause
./bin/clang-format-fixrewriting tracked files and leaving a non-empty diff.Formatting updates
lib/Epub/Epub/ReferencePageNavigation.hsrc/SettingsList.hsrc/activities/boot_sleep/SleepActivity.cppsrc/activities/reader/EpubReaderActivity.cpptest/stable_page_navigation/StablePageNavigationTest.cppGenerated asset consistency
src/components/icons/keyboardIcons.hfromsrc/components/icons/keyboardIcons.manifestso the checked-in generated header matches current formatter output instead of editing generated content by hand.PATH="/usr/lib/llvm-21/bin:$PATH" ./bin/clang-format-fix git diff --exit-code