Repository navigation
Refactor component to use projectsyn/jsonnet-libs's alerts.libsonnet - #57
Merged
Merged
Conversation
|
🚀 This PR has been released as Triggering workflows 🛠️ Auto tagging enabled with label |
|
🚀 Merging this PR will release Merging will trigger workflows 🛠️ Auto tagging enabled with label |
DebakelOrakel
force-pushed
the
change/alert-patching
branch
from
September 11, 2026 09:11
d2c331e to
ed3c563
Compare
simu
requested changes
Sep 11, 2026
| }, | ||
| }; | ||
|
|
||
| local registryAlerts = prom.generateRules('registry-cache', params.rules) { |
Member
There was a problem hiding this comment.
Please keep this, this works for both components.
We've moved the core logic of openshift4-monitoring-alert-patching.libsonnet and prom.generateRules() to projectsyn/jsonnet-libs (cf. projectsyn/jsonnet-libs#13). This commit updates the compnent to use that generic library.
DebakelOrakel
force-pushed
the
change/alert-patching
branch
from
October 1, 2026 06:36
ed3c563 to
a0993f3
Compare
simu
approved these changes
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We've moved the core logic of openshift4-monitoring-alert-patching.libsonnet and prom.generateRules() to projectsyn/jsonnet-libs (cf. projectsyn/jsonnet-libs#13).
This commit updates the compnent to use that generic library.
Checklist
changelog.
The PR has a meaningful description that sums up the change. It will be
linked in the changelog.
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog.