Implement support for Commodore component dependencies (SDD #0034) - #1418
Draft
simu wants to merge 17 commits into
Draft
Implement support for Commodore component dependencies (SDD #0034)#1418simu wants to merge 17 commits into
simu wants to merge 17 commits into
Conversation
simu
force-pushed
the
feat/component-dependencies
branch
4 times, most recently
from
August 18, 2026 13:58
3be1267 to
8254de4
Compare
5 tasks
simu
force-pushed
the
feat/component-dependencies
branch
3 times, most recently
from
August 19, 2026 15:11
30b425e to
3f33e49
Compare
`requiredif` NYI
TODO: cleanup, decide if/how we want to do nested component dependencies
simu
force-pushed
the
feat/component-dependencies
branch
from
August 20, 2026 13:16
a7f5c47 to
1af9818
Compare
We use Google's cel-expr-python to evaluate CEL. This requires bumping the minimum supported Python to 3.11. TODO: Move dropping Python 3.10 support to separate PR.
…'t use explicit component dependencies
simu
force-pushed
the
feat/component-dependencies
branch
2 times, most recently
from
August 20, 2026 13:58
78b5583 to
2079727
Compare
simu
force-pushed
the
feat/component-dependencies
branch
from
August 21, 2026 07:44
2079727 to
86fa65c
Compare
simu
force-pushed
the
feat/component-dependencies
branch
2 times, most recently
from
August 21, 2026 09:58
d6fbec7 to
ee6e550
Compare
…cases TODO: Verify compatibility
This is necessary now that we use the real `argocd.libsonnet` in `component compile` to ensure that `make golden-diff` doesn't fail on freshly templated components. We also introduce a command line flag `--update-golden-tests` for `component new` and `component update`. This flag is true by default, but we disable it in most component template unit/integration tests since we generally don't care about accuracy of the golden test outputs in these tests. However, for specific test cases (such as the one checking that a freshly templated component has no golden diff), we enable the flag.
simu
force-pushed
the
feat/component-dependencies
branch
from
August 21, 2026 11:02
ee6e550 to
70bf3d9
Compare
TODO: good test cases for recursive discovery (e.g. component minversion changes after first iteration).
simu
force-pushed
the
feat/component-dependencies
branch
4 times, most recently
from
August 21, 2026 12:45
4401132 to
b9fd11b
Compare
Some of these cases were previously covered by `component compile` tests. Note that we don't try to test the case where the `jb` binary is missing since we can't easily do that without breaking the global test environment.
simu
force-pushed
the
feat/component-dependencies
branch
from
August 21, 2026 12:50
b9fd11b to
2f1943a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SDD PR: projectsyn/documentation#189
TODO
component compileimplementationcomponent compile?argocddependency isn't injected for component-argocd (check by URL?)Checklist
bug,enhancement,documentation,change,breaking,dependency,internalas they show up in the changelog