Repository navigation
Fix Quarkus container image not pushed during Central release - #152
Merged
Merged
Conversation
release:perform forks a separate Maven build in target/checkout that only inherits properties passed via -Darguments. The Quarkus container-image flags were appended to the outer release command, so the forked build never saw them and no image was built or pushed (snapshot builds were unaffected since they run a plain `mvn deploy` with no fork). Inject the container-image flags into -Darguments instead, falling back to creating one if the release command has none. No input defaults or contracts change, so other callers are unaffected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
release:perform forks a separate Maven build in target/checkout that only inherits properties passed via -Darguments. The Quarkus container-image flags were appended to the outer release command, so the forked build never saw them and no image was built or pushed (snapshot builds were unaffected since they run a plain
mvn deploywith no fork).Inject the container-image flags into -Darguments instead, falling back to creating one if the release command has none. No input defaults or contracts change, so other callers are unaffected.