Skip to content

Clarify payout wording for coin-denominated bounties#413

Open
Rovynhq wants to merge 3 commits into
profullstack:masterfrom
Rovynhq:master
Open

Clarify payout wording for coin-denominated bounties#413
Rovynhq wants to merge 3 commits into
profullstack:masterfrom
Rovynhq:master

Conversation

@Rovynhq
Copy link
Copy Markdown

@Rovynhq Rovynhq commented Jun 5, 2026

Closes #401

Summary

  • update the shared formatBountyPayout helper so coin-denominated payouts read as Pays $X.XX USD in COIN
  • keep the payout semantics unchanged while removing the easy misread of $1.00 USD (paid in SOL) as 1 SOL
  • preserve the existing single-source-of-truth path already used by the bounty list, detail, and dashboard views

Why this fix

The existing label is technically correct, but it front-loads the dollar amount and then appends the coin in parentheses, which makes payout_usd: 1, payment_coin: "SOL" easy to misread as 1 SOL.

The new wording keeps the same underlying data and avoids implying that the numeric amount belongs to the coin itself.

Scope

  • src/lib/bounties.ts

Because the existing pages already call the shared formatter, no call-site changes were needed for the list/detail/dashboard views.

Validation

  • confirmed formatBountyPayout is the shared helper used by the bounty browse page, bounty detail page, and dashboard submissions/created views
  • verified the change is display-only and does not alter payout values or storage fields

@greptile-apps
Copy link
Copy Markdown

greptile-apps Bot commented Jun 5, 2026

Greptile Summary

This PR updates formatBountyPayout so both the coin-denominated and non-coin branches consistently prefix the output with "Pays", and removes the now-redundant trailing " payout" word from the dashboard submissions row. The change is display-only and does not touch payout values or storage fields.

  • src/lib/bounties.ts: both branches now return "Pays $X.XX USD [in COIN]", resolving the prior format inconsistency flagged in review.
  • src/app/dashboard/bounties/page.tsx: drops the literal payout suffix from the submissions list item since "Pays" is now embedded in the formatter string.
  • Unmodified call sites (bounties/page.tsx, bounties/[id]/page.tsx, dashboard created-bounties section) all inherit the new wording automatically; the bounty detail PriceBox now displays a verb-prefixed sentence in a 2xl-bold amount slot alongside a built-in dollar-sign icon.

Confidence Score: 5/5

Safe to merge — the change is purely cosmetic, no payout values or data storage fields are affected.

Both branches of formatBountyPayout now consistently use the "Pays" prefix, the dashboard submissions row correctly sheds its redundant trailing word, and no call site omits a required data update. The only open question is aesthetic: the verb-prefixed string appears in PriceBox.amount (rendered in large bold type beside a dollar-sign icon), which is slightly awkward but not functionally broken.

No files require special attention for correctness; the PriceBox usage in src/app/bounties/[id]/page.tsx is worth a visual spot-check after merging.

Important Files Changed

Filename Overview
src/lib/bounties.ts Rewrites formatBountyPayout to prefix both branches with "Pays", resolving the prior format inconsistency and changing the coin path from parenthetical to inline phrasing.
src/app/dashboard/bounties/page.tsx Removes the trailing " payout" word from the submissions row since the formatter now includes "Pays" — correct cleanup for the flowing-text context.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A["formatBountyPayout(amountUsd, paymentCoin)"]
    A --> B{paymentCoin set?}
    B -- Yes --> C["'Pays $X.XX USD in COIN'"]
    B -- No --> D["'Pays $X.XX USD'"]

    C --> E["bounties/page.tsx list card\n(inline with DollarSign icon)"]
    C --> F["bounties/[id]/page.tsx PriceBox\n(2xl bold amount slot)"]
    C --> G["dashboard/bounties/page.tsx\ncreated bounties row (DollarSign icon)"]
    C --> H["dashboard/bounties/page.tsx\nsubmissions row · …"]

    D --> E
    D --> F
    D --> G
    D --> H
Loading

Reviews (3): Last reviewed commit: "Remove redundant payout suffix from dash..." | Re-trigger Greptile

Comment thread src/lib/bounties.ts Outdated
@Rovynhq
Copy link
Copy Markdown
Author

Rovynhq commented Jun 5, 2026

Follow-up pushed to address the Greptile note about the dashboard submissions label.

The branch now removes the trailing literal payout suffix in src/app/dashboard/bounties/page.tsx, so the submissions view renders the shared formatter output directly instead of Pays $X.XX USD in SOL payout.

Latest head commit: 8a2ba73.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Bounty payout display is misleading when payment_coin is set

1 participant