Repository navigation
Record outbound alert calls when line recording is enabled - #126
Merged
Merged
Conversation
ThreatCrush Security Scan14 finding(s) HIGH/CRITICAL: 2 | MEDIUM: 4 | LOW: 8
Snippets are redacted; ThreatCrush never prints matched credential material. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outbound alert calls bypassed the line's recording preference, leaving no audio in the inbox. Answered alerts now start MP3 recording for enabled lines and announce it. Recording-saved events update the call message, and playback/download resolves both incoming and alert session IDs. Lines with recording disabled keep their existing behavior.
Validation: 369 tests pass; TypeScript passes; lint has no errors (4 existing warnings). Added coverage for enabled/disabled alert recording, recording duration, and outbound recording playback.