0.6.2: fix process termination dialog and add optional SIGKILL - #90
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The demo's process confirmation previously kept Yes visually focused and closed without sending a signal. The dialog now supports Yes/No keyboard navigation and an unchecked Force kill (-9 / SIGKILL) checkbox, sending SIGTERM by default and reporting signal results or errors.
Modal buttons and custom controls share keyboard focus, exclude background controls, consume activation keys, and restore focus after dismissal. The selected PID is captured when opening the dialog so metric refresh sorting cannot change the target; simulation never signals host processes. The component example, help and README explain the interaction.
Release both npm packages as 0.6.2, with matching workspace dependencies, CLI versions and website badge. This preserves the spinner changes already released in 0.6.1.
Validation: complete typecheck/build; 394 passing tests on Bun and Node; site production build; widget galleries and generated catalog consistency; disposable-child SIGTERM cleanup and SIGKILL checks; modal renderer benchmark; git diff --check.