gh-pulse: quiet cron, a clamped spinner, a rescan that rescans (0.36.1) - #73
Merged
Merged
Conversation
Follow-ups from a review of the busy indicator. The daily run handed its per-ten progress counts to the plain logger when stderr was not a terminal, so every cron.log grew ~70 lines it never had; the counts now ride the spinner only on a terminal and cron prints exactly what it printed before. The command-line spinner clamps its row to the terminal width (an overlong row walked down the screen a row per tick) and stops exactly once (the range path could stop it twice and print the last line twice). In the TUI, `r` finally forces a rescan (force was dropped at the ShowOptions boundary and the hour-fresh cache came back), a "still scanning" notice no longer outlives the scan, and the loading range button uses the ascii frames on a terminal without Unicode, like the spinner line does. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011gfb1vcQH5rf82HfbJvf1Z
ThreatCrush Security Scan13 finding(s) HIGH/CRITICAL: 4 | MEDIUM: 5 | LOW: 4
Snippets are redacted; ThreatCrush never prints matched credential material. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Follow-ups from an adversarial review of the busy indicator shipped in 0.35.0 (each finding verified against the source):
env -i).\r\x1b[Konly clears the last physical row of a wrapped line, so an overlong row walked down the screen a row per tick. Clamped with an ellipsis; the final line still prints whole.done()is idempotent. The--rangepath could call it twice (once on success, again from the catch if the read after it threw) and print the last line twice; it is now a try/finally and stops once.rrescans.forcewas dropped at theShowOptions.loadRangeboundary, so within an hour of any scanrshowed "rescanning" for a microtask and returned the cache. Threaded through.capabilities.unicode.Tested
tsc --noEmitbaseline only; full suite 969 pass; cron-like dry run shows coarse lines only.🤖 Generated with Claude Code
https://claude.ai/code/session_011gfb1vcQH5rf82HfbJvf1Z