Conversation
…ication failure Delete the decrypted file on disk if GCM decryption or authentication tag validation fails. Before unauthenticated plaintexts were left on disk. Additionally, avoid executing the configured open command template when decryption fails to prevent remote command execution on unauthenticated/corrupted payloads. Signed-off-by: Michael Vetter <jubalh@iodoru.org>
… check Use libgcrypts secure memory functions for plaintext buffers in OMEMO encryption and decryption. This ensures decrypted chat messages do not reside in cleartext on the standard heap or get swapped to disk. And are zeroed later. Add safety and bounds checks on PKCS#5 padding during decryption to prevent potential OOB reads when processing malformed or truncated ciphertexts. Signed-off-by: Michael Vetter <jubalh@iodoru.org>
Scrub sensitive cleartext strings using a `volatile` write pattern before they are released back to the heap. Use it in * Session saved PW * XMPP account passwords in `account_free()` * GPG passphrases and passphrase attempts Signed-off-by: Michael Vetter <jubalh@iodoru.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Protect against heap dump attacks.
Prevent OS from writing sensitive information to SWAP.
Protect against payload spoofing.