Repository navigation
Decode HTML named entities in malformed feeds - #351
Merged
Merged
Conversation
Feeds that copy HTML entities like Ä or fail to parse, and the escaping retry turned them into literal text. The retry now maps the HTML 4 named entities to numeric character references before escaping bare ampersands. The retry also never ran in two places. On web the DOMParser doesn't throw on malformed XML, it returns a parsererror document that decodes to an empty or truncated feed: that is now reported as a failure. On Android the nested-tag recovery in nextTrimmedText, added in 6.1.1, swallowed entity errors too, dropping the text before a bare ampersand: it now only recovers when the parser stopped on a child tag. Fixes #204
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The escaping retry for malformed feeds now turns HTML named entities like
Äand into numeric references, so they come out as the right characters instead of literal text. The retry also runs on web, where DOMParser parse errors used to give an empty feed, and on Android, where the nested-tag recovery added in 6.1.1 swallowed entity errors and dropped text before a bare&. Fixes #204.