Skip to content

Let cancelling the caller cancel the fetch and the parsing - #350

Merged
prof18 merged 1 commit into
masterfrom
fix/caller-cancellation
Nov 8, 2026
Merged

prof18 merged 1 commit into
masterfrom
fix/caller-cancellation

Conversation

@prof18

@prof18 prof18 commented Nov 8, 2026

Copy link
Copy Markdown
Owner

getRssChannel and parse ran under the parser's own SupervisorJob, so cancelling the caller didn't cancel the request or the parsing, and the caller kept waiting for it. They now run on Dispatchers.Default only, so cancellation reaches the fetch; RssParserCancellationTest covers it.

@prof18
prof18 enabled auto-merge (rebase) November 8, 2026 14:12
@prof18
prof18 merged commit d4091c4 into master Nov 8, 2026
10 checks passed
@prof18
prof18 deleted the fix/caller-cancellation branch November 8, 2026 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant