Repository navigation
chore(deps-dev): match @types/node to Node.js 24 - #18
Merged
Merged
Conversation
CI runs on Node.js 24, but the project still used the Node.js 20 type definitions, and Dependabot proposed jumping to Node.js 26. Use @types/node 24 so the types describe the runtime the code actually runs on. Skip @types/node major updates in Dependabot: they should change only when the Node.js version used in CI changes.
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces #17, which would move
@types/nodefrom 20 to 26.@types/nodeis set to^24(24.19.2). With version 26 types, code could use Node.js 26 features that fail on Node.js 24 without TypeScript reporting an error.@types/nodemajor updates. Update it by hand when the Node.js version in CI changes.Checks
npm ci(clean install from the currentmainlockfile)npm run lint(0 errors; 1 existing warning insrc/lib/legal.ts)npm run typechecknpm test(114 pass, 2 skipped)npm run buildReview notes
#17 can be closed once this is merged. If the Vercel project is set to a different Node.js version, align it with CI (24).