Repository navigation
Conversation
mremond
force-pushed
the
fm/task-eda90d1c
branch
from
November 14, 2026 18:29
5b63abc to
4fcd512
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A supervisor restarting a child must not race deletion of the child's named ETS table.
What changed
Before and after
Before: The new fixture failed all ten runs on the unchanged native runtime when immediate table recreation raised badarg.
After: The fixture passes ten runs with default native schedulers, ten with one scheduler, and ten on OTP 29.1.2.
This changes runtime exit ordering, which has no visible screen.
Checked
Live validation: Demonstrated for this version. 3 of 4 scenarios driven live in the product.
How it was checked
cargo build --release --locked -p nera-runtime, then -p nera, then the workspace
cargo clippy --workspace --all-targets --locked -- -D warnings
cargo test --workspace --locked --no-fail-fast
python3 scripts/test-allocator-config.py
./target/release/nera test -j 1 --timeout 30
python3 scripts/test-stacktrace-order.py
python3 scripts/test-native-shutdown.py: largest median 1.16 ms, below the prescribed 5 ms limit; maximum sample 11.24 ms, with no maximum-latency guarantee
Ten consecutive runs each of exit_deletes_ets_before_any_signal and owner_exit_releases_only_its_named_table
The unchanged ets_freed_before_signal fixture ran ten times per engine/scheduler mode with explicit fixture and return completion markers
Risk
Risk above low: Blast radius, medium — All native exit paths share this scheduler cleanup phase.
Full risk assessment
Not done
ETS heir support is outside this deletion-order change.
Pipeline
Updates from git push no-mistakes
Infinitary checked this version: an independent review that also judged the documents, and live validation the review accepted.